Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There's few core coding standards violations should be fixed before module can go to core
Comment | File | Size | Author |
---|---|---|---|
#8 | 2920498-8.patch | 14.27 KB | andypost |
Comments
Comment #2
andypostAfter #2920479: Get rid of rendering in hook_help
Comment #3
jhodgdonGood! I'll take a look at the test bot output in detail and make a patch here.
Comment #4
jhodgdonBesides the sniffs, let's also fix this review from comment #13 on the related issue here:
if ($body) should be enough
Comment #5
jhodgdonAlso fixing this one here:
Looks it needs default value - empty array
Comment #6
jhodgdonHere's a patch for the specific things here, as well as I hope the Coder warnings/errors from the test bot.
The config_help tests passed locally, so I'm committing it to the Sandbox now, and will shortly updating the Core patch on #2920309-23: Add experimental module for Help Topics. After that test bot run, we can see if there are more fixes needed to get rid of all Coder warnings. Until then, leaving this at Needs Review.
Comment #7
jhodgdonThe latest tests on the bot show no coding standards problems, so I think I will go ahead and close this as Fixed.
Not sure if it does warnings or only errors... if there are warnings we should fix, we can reopen this issue.
Comment #8
andypostCore sniffers are limited so here is fixes from DrupalPractice & core remains that still in work #2571965: [meta] Fix PHP coding standards in core
Comment #9
andypostPatch in #9 based on top of #2920839: See if we can use a route provider
Comment #10
jhodgdonThanks, this all looks great to me. Committed to Sandbox and I'm updating the Core patch as well.