Follow-up to #2490966: [Meta] Replace deprecated usage of entity_create with a direct call to the entity type class

Problem/Motivation

According to #2346261: Deprecate entity_create() in favor of a <EntityType>::create($values) or \Drupal::entityManager()->getStorage($entity_type)->create($values), entity_create() function is going to be deprecated so we shouldn't use it anymore. When the entity type is known we should directly call <EntityType>::create(). What to do when the entity type is not known or is variable is upon discussions.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task
Issue priority Normal because it's just about code cleanup and good practices
Prioritized changes The main goal of this issue is DX, performance and removing code already deprecated for 8.0.0. (Direct calls to EntityType::create are better than generic calls to entity_create for readability)
Disruption This change is not disruptive at all as it only replaces deprecated functions call by their exact equivalent.

Proposed resolution

Replace the deprecated call to entity_create() by a proper call to <EntityType>::create().

Before:

entity_create('field_config', $field_values)->save();

After:

use Drupal\field\Entity\FieldConfig;
FieldConfig::create($field_values)->save();

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions Done
Manually test the patch Novice Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

User interface changes

None.

API changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mac_Weber created an issue. See original summary.

Mac_Weber’s picture

Status: Needs review » Needs work
FileSize
3.26 KB
Mac_Weber’s picture

Issue summary: View changes
Mac_Weber’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: entity_test_mulrev-2641540-2.patch, failed testing.

Mac_Weber’s picture

FileSize
3.26 KB
Mac_Weber’s picture

FileSize
3.02 KB

Submitted the same broken patch =P

Mac_Weber’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: entity_test_mulrev-2641540-8.patch, failed testing.

Mac_Weber’s picture

Status: Needs work » Needs review
FileSize
3.02 KB

Fixed class aliasing

Wim Leers’s picture

Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: entity_test_mulrev-2641540-11.patch, failed testing.

naveenvalecha’s picture

Component: serialization.module » documentation
Status: Needs work » Reviewed & tested by the community

RTBC as per #12

naveenvalecha’s picture

Version: 8.1.x-dev » 8.0.x-dev
naveenvalecha’s picture

Version: 8.0.x-dev » 8.1.x-dev
Component: documentation » serialization.module

oops #14 Wrong component change

Wim Leers’s picture

That was a testbot fluke. Hence it's green now.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 7310ef8 and pushed to 8.0.x and 8.1.x as this only changes test code. Thanks!

  • alexpott committed 2ecea88 on
    Issue #2641540 by Mac_Weber: Replace deprecated usage of  entity_create...

  • alexpott committed 7310ef8 on
    Issue #2641540 by Mac_Weber: Replace deprecated usage of  entity_create...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.