Follow-up to #2490966: [Meta] Replace deprecated usage of entity_create with a direct call to the entity type class
Problem/Motivation
According to #2346261: Deprecate entity_create() in favor of a <EntityType>::create($values) or \Drupal::entityManager()->getStorage($entity_type)->create($values), entity_create() function is going to be deprecated so we shouldn't use it anymore. When the entity type is known we should directly call <EntityType>::create()
. What to do when the entity type is not known or is variable is upon discussions.
Beta phase evaluation
Issue category | Task |
---|---|
Issue priority | Normal because it's just about code cleanup and good practices |
Prioritized changes | The main goal of this issue is DX, performance and removing code already deprecated for 8.0.0. (Direct calls to EntityType::create are better than generic calls to entity_create for readability) |
Disruption | This change is not disruptive at all as it only replaces deprecated functions call by their exact equivalent. |
Proposed resolution
Replace the deprecated call to entity_create()
by a proper call to <EntityType>::create()
.
Before:
entity_create('field_config', $field_values)->save();
After:
use Drupal\field\Entity\FieldConfig;
FieldConfig::create($field_values)->save();
Remaining tasks
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Create a patch | Instructions | Done | |
Manually test the patch | Novice | Instructions | |
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions |
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#11 | entity_test_mulrev-2641540-11.patch | 3.02 KB | Mac_Weber |
Comments
Comment #2
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedComment #3
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedComment #4
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedComment #6
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedComment #7
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedComment #8
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedSubmitted the same broken patch =P
Comment #9
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedComment #11
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedFixed class aliasing
Comment #12
Wim LeersComment #14
naveenvalechaRTBC as per #12
Comment #15
naveenvalechaComment #16
naveenvalechaoops #14 Wrong component change
Comment #17
Wim LeersThat was a testbot fluke. Hence it's green now.
Comment #18
alexpottCommitted 7310ef8 and pushed to 8.0.x and 8.1.x as this only changes test code. Thanks!