Problem/Motivation

The documentation for links template at links.html.twig and template_preprocess_links points to an href element, which no longer exists. This is confusing and I had to check the code to make sure that it was indeed not used.

This could be considered a task but I filed it as a bug because it is incorrect documentation.

Proposed resolution

Fix the documentation with correct names and remove outdated references.

Remaining tasks

Patch, Review, Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 fix_documentation_for_links-2639656-2.patch4.21 KBhussainweb

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new fix_documentation_for_links-2639656-2.patch4.21 KB

Here is a patch as per above.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Closed (duplicate)

This is a direct duplicate of #2620854: links.html.twig docs are out of date

hussainweb’s picture

hussainweb
Primary language English
commented

I searched with all variations I could and didn't find it. :) Thanks for pointing to the issue.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

They happened to be right next to each other in my issue queue. :)

I'm not sure the other one covers template_preprocess so maybe add that to the other patch?

hussainweb’s picture

hussainweb
Primary language English
commented

Yes, I did that and explained the differences in both patches in #2620854-8: links.html.twig docs are out of date.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Perfect, thanks very much!