Closed (fixed)
Project:
Mollom
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
7 Oct 2015 at 19:12 UTC
Updated:
13 Nov 2015 at 15:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
drummhttp://cgit.drupalcode.org/drupalorg/commit/?id=40dc5a3 is Drupal.org's tentative implementation. And the patch is attached.
Comment #4
drummThe failing test is due to #2503171: Remove content moderation platform.
Comment #5
nick_vhPatch is looking good. Going to wait what eshta is saying about it before RTBC'ing it.
Comment #6
eshta commentedStrange... the only commit made for the CMP removal was on the 8.x branch and the test failure is on the 7.x-2.x branch. I'll look into that.
In the meantime, I see that the hook is added to mollom_form_get_values(). This is called before submitting textual analysis, captcha, after form submission, and upon sending feedback to Mollom. It seems to me that you are only really looking to alter data in the textual analysis case. In the other cases, I can't see a reason that we'd want to allow manipulation of the contents sent. Also - in the textual analysis case the module continues to manipulate the data after this hook is called and before sending to Mollom (which may have been your intent?). I'm wondering if it might be better to place it right before the call to checkContent() within mollom_validate_analysis() here: http://cgit.drupalcode.org/mollom/tree/mollom.module#n2185
Comment #7
drummThat location works for me, attached is an updated patch.
Comment #9
drummSame as #4, I updated #2503171: Remove content moderation platform with some details.
Comment #11
eshta commentedWe should actually call this something different since there is already a mollom_data_insert, mollom_data_update, and mollom_data_delete hooks that refer to the data stored from mollom responses. mollom_content_alter works for me since it is the content analyzed by checkContent call. If this names works, though, it's RTBC to me.
Comment #12
eshta commentedminor semantics in api file
Comment #21
drummLooks like dev.mollom.com is returning HTTP 900 to the testbots. Maybe their IP got blacklisted? As far as I know, there have been no changes on Drupal.org's side, and the instances running D6 & 7 tests are relatively long-lived.
The patch does look good.
Comment #24
eshta commentedBack-porting....
Comment #26
eshta commented