For #2529118: Whitelist certain urls for Mollom spam checks , Nick_vh suggested altering the data being sent to Mollom, since a whitelisting feature is not expected on the roadmap. We'll remove domains we know are safe via a hook implementation.

Comments

drumm created an issue. See original summary.

drumm’s picture

Status: Active » Needs review
StatusFileSize
new1.23 KB

http://cgit.drupalcode.org/drupalorg/commit/?id=40dc5a3 is Drupal.org's tentative implementation. And the patch is attached.

Status: Needs review » Needs work

The last submitted patch, 2: 2582417.diff, failed testing.

drumm’s picture

Status: Needs work » Needs review
nick_vh’s picture

Patch is looking good. Going to wait what eshta is saying about it before RTBC'ing it.

eshta’s picture

Strange... the only commit made for the CMP removal was on the 8.x branch and the test failure is on the 7.x-2.x branch. I'll look into that.

In the meantime, I see that the hook is added to mollom_form_get_values(). This is called before submitting textual analysis, captcha, after form submission, and upon sending feedback to Mollom. It seems to me that you are only really looking to alter data in the textual analysis case. In the other cases, I can't see a reason that we'd want to allow manipulation of the contents sent. Also - in the textual analysis case the module continues to manipulate the data after this hook is called and before sending to Mollom (which may have been your intent?). I'm wondering if it might be better to place it right before the call to checkContent() within mollom_validate_analysis() here: http://cgit.drupalcode.org/mollom/tree/mollom.module#n2185

drumm’s picture

StatusFileSize
new1.24 KB

That location works for me, attached is an updated patch.

Status: Needs review » Needs work

The last submitted patch, 7: 2582417.diff, failed testing.

drumm’s picture

Status: Needs work » Needs review

Same as #4, I updated #2503171: Remove content moderation platform with some details.

drumm queued 7: 2582417.diff for re-testing.

eshta’s picture

We should actually call this something different since there is already a mollom_data_insert, mollom_data_update, and mollom_data_delete hooks that refer to the data stored from mollom responses. mollom_content_alter works for me since it is the content analyzed by checkContent call. If this names works, though, it's RTBC to me.

eshta’s picture

minor semantics in api file

The last submitted patch, 11: 2582417.mollom.alter_content_submit.11.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 12: 2582417.mollom.alter_content_submit.12.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: 2582417.mollom.alter_content_submit.12.patch, failed testing.

eshta queued 7: 2582417.diff for re-testing.

The last submitted patch, 7: 2582417.diff, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: 2582417.mollom.alter_content_submit.12.patch, failed testing.

drumm’s picture

Status: Needs work » Reviewed & tested by the community

Looks like dev.mollom.com is returning HTTP 900 to the testbots. Maybe their IP got blacklisted? As far as I know, there have been no changes on Drupal.org's side, and the instances running D6 & 7 tests are relatively long-lived.

The patch does look good.

  • eshta committed dd36572 on 7.x-2.x authored by drumm
    Issue #2582417 by drumm, eshta: Allow data in mollom_form_get_values()...
eshta’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new1.28 KB

Back-porting....

  • eshta committed e2ae60f on authored by drumm
    Issue #2582417 by drumm, eshta: Allow data in mollom_form_get_values()...
eshta’s picture

Status: Needs review » Fixed

  • eshta committed d733b9f on 8.x-1.x
    Issue #2582417 by eshta, drumm: Allow data in mollom_form_get_values()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.