Prevent users from editing a content type's machine name once it has been set

Drupal 7 used to have https://api.drupal.org/api/drupal/modules%21field%21field.attach.inc/fun...

I have no idea what the 8.x equivalent is, but even if we have it, we're clearly not implementing it.

Bumping to critical since this is a clear data-loss issue. We can prevent the rename for now as a quick fix, then handle renames properly and remove the validation later IMO.

Also need to check if this is an issue for taxonomy vocabularies or other entity types in core that have a bundle config entity.

Working on this.

This hook was removed in #1374116: Move bundle CRUD API out of Field API where it was renamed hook_entity_bundle_rename(), not hook_entity_rename_bundle() as said on the issue.

The problem is that this hook is triggered by an entity::postSave(), so it happens too late to prevent the change, and a complete fix will have to be extensive, possibly involving an API change, so let's just do it in the entity type forms.

We have 4 entity types in core where this happens, not counting tests: node, taxonomy_term, shortcut, and block_content, with bundle edit forms. The latter two already have a form-based protection, so I replicated the same policy on the two former ones. Let's see how the tests fare.

Adjusting component.

Personally renaming bundles is a vulcano. It would require adaption all over the place.

Personally this is a feature that can be provided by contrib modules.

We ought to be able to detect the change in save somewhere, and throw an exception there?

--- a/core/modules/node/src/NodeTypeForm.php
+++ b/core/modules/node/src/NodeTypeForm.php

--- a/core/modules/shortcut/src/ShortcutSetForm.php
+++ b/core/modules/shortcut/src/ShortcutSetForm.php

--- a/core/modules/taxonomy/src/VocabularyForm.php
+++ b/core/modules/taxonomy/src/VocabularyForm.php

I haven't looked too far into how this might work in EntityForm (which all 3 of these extend), but it would be really great if we could generically dis-allow changing the machine name for any entity type with existing content (simply disallowing it at all after creation would be fine too, but would perhaps be frustrating for devs prone to typos :)

Edit: EntityForm is probably too generic, but perhaps a trait the given entity type forms could use?

The Book module tests for the ability to change machine name (as if that were a feature?), so a change notice will be needed I suppose:

  function testBookNodeTypeChange() {
    $this->drupalLogin($this->adminUser);
    // Change the name, machine name and description.
    $edit = array(
      'name' => 'Bar',
      'type' => 'bar',
    );

We ought to be able to detect the change in save somewhere, and throw an exception there?

My thoughts exactly.

So I think we want to have two things:

• Something like BundleConfigEntityFormBase (Adds validation + the #disabled flag by default)
• Maybe also add a similar base class for config entities itself and validate the renaming of the entity KEY there.

The current patch should at least document for the #disabled flags, why they are setup in this particular way.

I've been updating the path to catch the change in the storage layer, to avoid depending only on UI, as suggested by @catch. It doesn't prevent doing it in the UI to avoid exposing an otherwise unavailable rename operation, of course.

Question is: what to do about BookTest, for instance, which explicitly tests renaming a node bundle : do we just drop the test ?

I think we can just drop the test for now yes, that hunk could move to the follow-up issue to add back the feature.

Duplicate of #2172843: Remove ability to update entity bundle machine names which has unfortunately been around for a long time with a patch.