Problem/Motivation

https://git.drupalcode.org/issue/drupal-3522004/-/jobs/5114070

This is very slow, but it's not marked with @group #slow.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3522021

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !11991

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

No brainer

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Found some more Migrate tests we should add this to. What tends to happen is when tests are added removed, eventually it shuffles the ordering that ones which used to start at the beginning of the job by accident without explicitly being marked #slow end up starting later and finishing at or near the end of the job.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

LGTM!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 11.1.x-dev
Status: Reviewed & tested by the community » Fixed

I wish we could just make PHPUnit responsible for this and remove #slow completely. It should just run the slowest tests from the last run first...

Committed and pushed bccd5a0c920 to 11.x and f2a221b3523 to 11.2.x and 00080f5aa17 to 11.1.x. Thanks!

Backported to 11.1.x as a test only change.

  • alexpott committed 00080f5a on 11.1.x 
    Issue #3522021 by catch: Add @group #slow to MigrateDrupal7AuditIdsTest...

  • alexpott committed f2a221b3 on 11.2.x 
    Issue #3522021 by catch: Add @group #slow to MigrateDrupal7AuditIdsTest...

  • alexpott committed bccd5a0c on 11.x 
    Issue #3522021 by catch: Add @group #slow to MigrateDrupal7AuditIdsTest
mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#3523614: [CI] Refactor DeprecationHandler in a standard PHPUnit extension, and collect deprecation statistics

I wish we could just make PHPUnit responsible for this and remove #slow completely. It should just run the slowest tests from the last run first...

I think we are close to be able to do that. IMO the hardest part is to consolidate test time results from the multiple spawns of run-test.sh and again from the multiple CI jobs. Good news is that a PoC to get a consolidated artifact with all the data seem to work in #3523614: [CI] Refactor DeprecationHandler in a standard PHPUnit extension, and collect deprecation statistics. Once that's in, we could build on that logic to do the same for test time results.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.