CommentFileSizeAuthor
#7 Screenshot_v_api.png16.37 KBpearls

Issue fork votingapi-3509000

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tr created an issue. See original summary.

tr’s picture

tr commented
Issue summary: View changes

Also for related types like VoteType and VoteStorage.
VoteResultFunction plugins and manager will be handled in a separate issue.

tr opened merge request !48

tr’s picture

tr commented
Issue summary: View changes

I guess I don't have a choice, VoteResultFunction plugins are too intertwined, so have to work on the typing in those at the same time it seems.

  • tr committed ef653008 on 4.0.x 
    Issue #3509000 by tr: Strict typing and fluent interface for Vote entity
tr’s picture

tr commented
Status: Active » Fixed
pearls’s picture

pearls commented
StatusFileSize
new Screenshot_v_api.png16.37 KB

Here's the log with rate module after MR !48 merged.

TypeError: Drupal\votingapi\Entity\Vote::setValue(): Argument #1 ($value) must be of type float, null given, called in /var/www/html/d11site/web/modules/contrib/rate/src/Plugin/RateWidgetBase.php on line 316 in Drupal\votingapi\Entity\Vote->setValue() (line 92 of /var/www/html/d11site/web/modules/contrib/votingapi/src/Entity/Vote.php).

ArgumentCountError: Too few arguments to function Drupal\votingapi\Entity\Vote::setValue(), 0 passed in /var/www/html/d11site/web/modules/contrib/rate/src/Plugin/RateWidgetBase.php on line 316 and exactly 1 expected in Drupal\votingapi\Entity\Vote->setValue() (line 92 of /var/www/html/d11site/web/modules/contrib/votingapi/src/Entity/Vote.php).

Screenshot

tr’s picture

tr commented

That appears to be the Rate module calling the Vote API with a missing argument. That's a bug in Rate, which was revealed the above changes.

pearls’s picture

pearls commented

Ok.Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.