issue

CommentFileSizeAuthor
#8 after_patch.png7.49 KBtanuja bohra
#8 before_patch.png7.4 KBtanuja bohra
#7 Screenshot from 2024-04-09 19-05-23.png10.08 KBsourojeetpaul
#5 Screenshot from 2024-02-22 18-18-17.png50.1 KBdivya.sejekan
Screenshot 2024-02-14 at 6.10.25 PM.png38.25 KBalok_singh

Issue fork yg_iconic-3421367

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alok_singh created an issue. See original summary.

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: Unassigned » sourabhsisodia_

sourabhsisodia_ opened merge request !18

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: sourabhsisodia_ » Unassigned
Status: Active » Needs review
divya.sejekan’s picture

divya.sejekan commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2024-02-22 18-18-17.png50.1 KB

Tried with using MR , doesnt look fixed . Twitter is not updated to X

sourojeetpaul’s picture

sourojeetpaul commented
Assigned: Unassigned » sourojeetpaul

Looking into it!

sourojeetpaul’s picture

sourojeetpaul commented
Assigned: sourojeetpaul » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Screenshot from 2024-04-09 19-05-23.png10.08 KB

Hello there, I've updated MR!18 by adding reference to the latest fontawesome CDN on the libraries.yml where they have added the new twitter X logo and also altering the classes on page.html.twig as well as page--front.html.twig.
I think its a better idea to add CDN reference of fontawesome here, as in near future in case of such updation it'll be easier to do it rather than changing the whole file which resides locally on the theme.

After the changes the twitter logo has been updated to X now.
Footer Twitter Logo

tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch.png7.4 KB
new after_patch.png7.49 KB

Verified MR18 on 9.5.x, the Twitter icon is updated. RTBC++