Problem/Motivation

Starter Kit and Umami details.css contain this comment:

/* @todo Regression: The summary of uncollapsible details are no longer
     vertically aligned with the .details-wrapper in browsers without native
     details support. */

This was added in #3050384: Provide a starterkit theme in core
This is irrelevant because all browsers support <details> natively now.

Steps to reproduce

Proposed resolution

Remove the comment.

https://git.drupalcode.org/project/drupal/-/merge_requests/6437

Remaining tasks

Review/Commit

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

CommentFileSizeAuthor
#2 3418873-02.patch1.25 KBkeshav patel

Issue fork drupal-3418873

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

keshav patel’s picture

keshav patel commented
Status: Active » Needs review
StatusFileSize
new 3418873-02.patch1.25 KB

@longwave Removed the comment from css files please review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Please turn to MR.

Keshav Patel opened merge request !6437

keshav patel’s picture

keshav patel commented
Status: Needs work » Needs review

Created MR as per #3.

shweta__sharma’s picture

shweta__sharma commented
Issue summary: View changes

Issue summary updated also changes seem good. The comment has been removed now.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative
quietone’s picture

quietone commented
Issue summary: View changes

The comments were added in #3050384: Provide a starterkit theme in core and it is supported on all browsers now. I also grepped for other instances, just in case and didn't find anything similar.

  • quietone committed c2958323 on 11.x 
    Issue #3418873 by Keshav Patel, longwave, shweta__sharma: Remove...
quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Fixed

Committed c295832 and pushed to 11.x. Thanks!

quietone closed merge request !6437

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.