Problem/Motivation

  • Expand the range of possible translations by Drupal.t().
  • Also, modify the translation to be able to translate by the translation file you have created.

Issue fork cloud-3355965

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1739

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. It looks good. I posted my minor comment. Thanks

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I pushed the commit for removing blank lines. Please review it again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. Can you please rebase the patch due to the previous merge? Thanks!

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I rebased this patch. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. I'll merge the patch to 4.x, 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Update Drupal.t() support in the SPA » Refactor to support Drupal.t() in the SPA

  • yas committed 3ad97c19 on 6.x authored by Ryo Yamashita 
    Issue #3355965 by Ryo Yamashita, yas: Refactor to support Drupal.t() in...

  • yas committed 0948f9de on 5.x authored by Ryo Yamashita 
    Issue #3355965 by Ryo Yamashita, yas: Refactor to support Drupal.t() in...

  • yas committed c27fee1b on 4.x authored by Ryo Yamashita 
    Issue #3355965 by Ryo Yamashita, yas: Refactor to support Drupal.t() in...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.