We should have checked if admin_toolbar_search was actually enabled before applying the changes.

CommentFileSizeAuthor
#5 admin_search_tab_3160156-5.patch20.72 KBSyfJO
#4 admin_search_tab_3160156-4.patch2.63 KBSyfJO
Screenshot from 2020-07-19 14-27-48.png2.51 KByahyaalhamad

Comments

YahyaAlHamad created an issue. See original summary.

jazzper’s picture

jazzper commented

Because of this?:
https://www.drupal.org/node/3122957

And thanks for this great module and the Root administration theme! The admin theme is super clean, intuitive and the best I've ever used!

yahyaalhamad’s picture

yahyaalhamad
Location Palestine
commented

Thank you @jazzper, we appreciate your nice remarks. This issue you linked is certainly the problem, maybe we can preprocess the serach tab a little bit to make it nice.

SyfJO’s picture

SyfJO
Location Jordan 🇯🇴.
commented
StatusFileSize
new admin_search_tab_3160156-4.patch2.63 KB

Here is a patch to solve this issue

SyfJO’s picture

SyfJO
Location Jordan 🇯🇴.
commented
StatusFileSize
new admin_search_tab_3160156-5.patch20.72 KB

Small fix to the patch in #4, files paths where wrong!
Hope this should fix the issue now.

  • YahyaAlHamad committed 96f6d06 on 8.x-1.x authored by SyfJO 
    Issue #3160156 by SyfJO, YahyaAlHamad, jazzper: Admin Toolbar search...
yahyaalhamad’s picture

yahyaalhamad
Location Palestine
commented
Status: Active » Fixed

Commited, thank you.

yahyaalhamad’s picture

yahyaalhamad
Location Palestine
commented
Issue summary: View changes
Status: Fixed » Needs work

  • YahyaAlHamad committed 5f02f22 on 8.x-1.x authored by SyfJO 
    Issue #3160156 by SyfJO, YahyaAlHamad: Admin Toolbar search button looks...
yahyaalhamad’s picture

yahyaalhamad
Location Palestine
commented
Status: Needs work » Fixed
yahyaalhamad’s picture

yahyaalhamad
Location Palestine
commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.