There are a few appearances of Drupal::foo() instead of \Drupal::foo() in Drupal Core.
Consistently use \Drupal::foo()

CommentFileSizeAuthor
#13 3082854-D9_0-13.patch11.85 KBspokje
#11 3082854-11.patch11.66 KBandypost
#8 3082854-5-D90.patch16.56 KBspokje
#7 3082854-4-D89.patch17.9 KBspokje
#3 3082854-3-D87.patch15 KBspokje
#2 3082854-2.patch17.48 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3082854-2.patch17.48 KB

Slight case of OCD + grep "[^\]Drupal::" -rl = attached patch

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3082854-3-D87.patch15 KB

#2 + big sigh = D8.7 patch

spokje’s picture

spokje
Primary language Dutch
commented
Title: Consistent use of \Drupal::foo() instead of Drupal::foo() » Consistently use of \Drupal::foo() instead of Drupal::foo()
Assigned: spokje » Unassigned
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Title: Consistently use of \Drupal::foo() instead of Drupal::foo() » Consistently use \Drupal::foo() instead of Drupal::foo()

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3082854-4-D89.patch17.9 KB
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3082854-5-D90.patch16.56 KB
spokje’s picture

spokje
Primary language Dutch
commented
Parent issue: » #2571965: [meta] Fix PHP coding standards in core, stage 1

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 3082854-11.patch11.66 KB

re-roll for 9.1

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

All the changes in this patch look good.
When I do a code base regex search for (?<!\\)Drupal::, I cannot find any more occurrences.
There is no PHPCS rule with this patch.
For me it is RTBC (only for the 9.1 patch, the 9.0 needs a reroll).

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3082854-D9_0-13.patch11.85 KB

Rerolled for D9.0

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Thanks for working on this!

+++ b/.gitignore
@@ -0,0 +1,5 @@
+.idea/
+modules/
+sites/default/
+sites/simpletest/
+vendor/

This shouldn't be included in the patch. #11 is probably good for 9.1 though, so hiding #13.

However, before we fix this, we should add a phpcs rule for it. There might be an issue already -- if not, let's file one?

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

quietone’s picture

quietone commented
Parent issue: #2571965: [meta] Fix PHP coding standards in core, stage 1 » #3188974: [Meta] Consistent use of leading \ for class names

There are several issues about the inconsistent use of the lead \ for class names. Adding this to the new meta for all such issues.

the other issues are postponed on a PHPCS rule. Should this issue be postponed as well?

spokje’s picture

spokje
Primary language Dutch
commented
Title: Consistently use \Drupal::foo() instead of Drupal::foo() » [PP-1] Consistently use \Drupal::foo() instead of Drupal::foo()
Status: Needs review » Postponed

the other issues are postponed on a PHPCS rule. Should this issue be postponed as well?

Yes, it is.

However, before we fix this, we should add a phpcs rule for it. There might be an issue already -- if not, let's file one?
xjm in #14

spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3054969: Add sniff for \Drupal vs Drupal

Added related issue on which this is postponed

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.