Problem/Motivation
This is a follow up to #2917883: Rename 'migration_templates' directories in core modules to 'migrations'. See #20
There are migrations in core that are prefixed with "migrate.migration" and that is not needed. It might be confused with migrations configured with migrate_plus which uses a prefix of 'migrate_plus.migration' and it is just extra typing as well.
Using find these files were discovered.
./core/modules/migrate/tests/modules/migrate_high_water_test/migrations/migrate.migration.high_water_test.yml
./core/modules/migrate/tests/modules/migrate_external_translated_test/migrations/migrate.migration.external_translated_test_node.yml
./core/modules/migrate/tests/modules/migrate_external_translated_test/migrations/migrate.migration.external_translated_test_node_translation.yml
Suitable for novice
Proposed resolution
Rename all such migration yml files to remove the prefix "migrate.migration."
Remaining tasks
Write a patch
Review
RTBC
Commit!
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Comments
Comment #2
quietone CreditAttribution: quietone as a volunteer commentedAdded novice tag.
Comment #3
shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer and at Iksula commentedpatch for renaming files.
Comment #4
quietone CreditAttribution: quietone as a volunteer commented@shashikant_chauhan, thanks for making the patch. It is nearly there!
Where you working from HEAD? The high_water_test.yml was moved from migration_templates to migrations directory.
When making this patch please use 'git diff -M' and check that the patch uses rename and does delete the file and then insert a new one. It just makes it much easier to review. Thanks!
Comment #5
Ivan Berezhnov CreditAttribution: Ivan Berezhnov as a volunteer and at Drupal Ukraine Community for Levi9 commentedComment #6
savkaviktor16@gmail.com CreditAttribution: savkaviktor16@gmail.com at Skilld commentedRe-rolled/remade the patch
Comment #7
savkaviktor16@gmail.com CreditAttribution: savkaviktor16@gmail.com at Skilld commentedComment #8
quietone CreditAttribution: quietone as a volunteer commentedThanks for the reroll and having it show renames. So much easier to review. Applied the patch and used find and did not find any files with the name 'migrate.migration' prepended to it.
Thanks Saviktor and shashikant_chauhan !
Comment #10
andypostRequeued, unrelated fail
Comment #11
xjmComment #13
quietone CreditAttribution: quietone as a volunteer commentedRetesting
Comment #14
quietone CreditAttribution: quietone as a volunteer commentedTests are passing again. Back to RTBC
Comment #16
quietone CreditAttribution: quietone as a volunteer commentedOnce again, the test aborted. Let's try again.
Comment #17
quietone CreditAttribution: quietone as a volunteer commentedBack to RTBC
Comment #19
jofitz CreditAttribution: jofitz at ComputerMinds commentedTests are back to green. Back to RTBC.
Comment #21
quietone CreditAttribution: quietone as a volunteer commentedA bit tired of this becoming NW. Re uploading the patch in an attempt to get testbot to stop marking this as failing.
Comment #23
D34dMan CreditAttribution: D34dMan as a volunteer and commentedRegarding the failing test cases, added the failed test as reference to the Drupal issue which is tracking it #2926309: Random fail due to APCu not being able to allocate memory
Comment #24
D34dMan CreditAttribution: D34dMan as a volunteer and commentedAfter doing the retest we have two fails which are irrelevant to this issue as mentioned by @andypost in #10. Thus marking it as RTBC.
Comment #27
quietone CreditAttribution: quietone as a volunteer commentedThe random failures have been fixed, #2926309: Random fail due to APCu not being able to allocate memory, and this is passing tests on 8.6.x. This is just renaming three files so let's go to NR.
Comment #28
phenaproximaI'm a bit concerned about the PHP 7.2 failures, but I know this patch didn't cause them. I think this is ready to go.
Comment #29
alexpott@phenaproxima those fails were from before PHP 7.2 was actually supported :)
Committed and pushed dd993b38f6 to 8.6.x and 50f0a25035 to 8.5.x. Thanks!
Backported to 8.5.x as this is a test-only change.