Found a really annoying bug.
If you have an inline colorbox and a non-inline colorbox (or tons of them doesn't matter), after you usethe inline colorbox, the others will fail.
This is due to colorbox_inline.js:

var settings = $.extend(drupalSettings.colorbox, {

That adds "inline":true to the drupalSettings.colorbox object. Since this is only to get the settings, it would be better to re-order the arguments to $.extend().

Comments

NickWilde created an issue. See original summary.

nickdickinsonwilde’s picture

Assigned: nickdickinsonwilde » Unassigned
Status: Active » Needs review
StatusFileSize
new498 bytes
nickdickinsonwilde’s picture

Status: Needs review » Fixed

  • NickWilde committed 8a72c9e on 8.x-1.x
    Issue #2920121 by NickWilde: Dirties the primary drupalSettings.colorbox...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.