As image shows, demo-block width is restricted. makes region look narrow.

CommentFileSizeAuthor
#2 2727523-header-demo-block-limits-display-width.patch703 bytesskaught
#2 bartik-demo-region-width-unlimited.png59.22 KBskaught
bartik-demo-region-width-limit.png99.71 KBskaught

Comments

SKAUGHT created an issue. See original summary.

skaught’s picture

skaught
Primary language English
commented
StatusFileSize
new bartik-demo-region-width-unlimited.png59.22 KB
new 2727523-header-demo-block-limits-display-width.patch703 bytes

patch applied

skaught’s picture

skaught
Primary language English
commented
Status: Active » Needs review
skaught’s picture

skaught
Primary language English
commented
Version: 8.1.1 » 8.1.x-dev
mcjim’s picture

mcjim commented

Looks good to me. Can't see a good reason for the 500px (was introduced in 3e610b85472fa06c825bc87121fac7ed44adc7d6).
I'll do my due diligence (i.e. cross-browser testing) as soon as I can (unless someone else jumps in first).

mcjim’s picture

mcjim commented
Status: Needs review » Reviewed & tested by the community

Tested on Edge, IE10, IE8, Safari, Firefox, Chrome.
Works as expected. Appears as in screenshot from #2.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: bartik 'header demo-block' limits display width. makes region look short. » Bartik's '.header .demo-block' needlessly sets width
Version: 8.1.x-dev » 8.2.x-dev

Looked up the issue this was introduced in: #929440-19: Demonstrate blocks regions could need some love
(Also, that was my first ever code sprint!)

When it was committed, the 500px only applied to the single header region via #header

In #2398453: Clean up the "admin" component in Bartik this was erroneously converted to .header, and it applied to more regions than before.

I think this is RTBC as well, but only for 8.2.x

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ea4a3fb and pushed to 8.2.x. Thanks!

less css, nice.

  • alexpott committed ea4a3fb on 8.2.x 
    Issue #2727523 by SKAUGHT: Bartik's '.header .demo-block' needlessly...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.