Watchdog() has been removed, we need to use `\Drupal::logger('seckit')`

CommentFileSizeAuthor
#6 interdiff.txt843 byteskmoll
#6 seckit-remove-watchdog-2711905-6.patch4.29 KBkmoll
#2 seckit-remove-watchdog-2711905-1.patch4.12 KBkmoll

Comments

kmoll created an issue. See original summary.

kmoll’s picture

kmoll commented
StatusFileSize
new seckit-remove-watchdog-2711905-1.patch4.12 KB

removed all occurrences of watchdog()

kmoll’s picture

kmoll commented
Status: Active » Needs review
badjava’s picture

badjava commented

@kmoll Looks good but I think the arguments should be passed directly to logger in the CSRF attack and not use the t() function.

badjava’s picture

badjava commented
Status: Needs review » Needs work
kmoll’s picture

kmoll commented
StatusFileSize
new seckit-remove-watchdog-2711905-6.patch4.29 KB
new interdiff.txt843 bytes

updated patch and created interdiff.

kmoll’s picture

kmoll commented
Status: Needs work » Needs review
bart vanhoutte’s picture

bart vanhoutte commented

I think this can be left out (SecKitEventSubscriber::_seckit_origin)?

$warning = t($message, $args);
bart vanhoutte’s picture

bart vanhoutte commented
Status: Needs review » Reviewed & tested by the community

Just saw the AccessDeniedException.

Fixed the watchdog missing error on my site. Looks good.

  • badjava committed 2a389bb on 8.x-1.x authored by kmoll 
    Issue #2711905 by kmoll: Watchdog has been removed from Drupal 8 -...
badjava’s picture

badjava commented
Status: Reviewed & tested by the community » Patch (to be ported)

Thank you Kevin and Bart for fixing this issue.

badjava’s picture

badjava commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.