TranslationWrapper should be used instead of t() in derivative defintions [#2539110]

  public function getDerivativeDefinitions($base_plugin_definition) {
    $block_contents = $this->blockContentStorage->loadMultiple();
    /** @var $block_content \Drupal\block_content\Entity\BlockContent */
    foreach ($block_contents as $block_content) {
      $this->derivatives[$block_content->uuid()] = $base_plugin_definition;
      // @todo what to do about this?
      $this->derivatives[$block_content->uuid()]['admin_label'] = $block_content->label();
      $this->derivatives[$block_content->uuid()]['config_dependencies']['content'] = array(
        $block_content->getConfigDependencyName()
      );
    }
    return parent::getDerivativeDefinitions($base_plugin_definition);
  }

This means that in the block admin ui it won't use a french content block title for the admin label if english has been viewed first - because the admin_label is cached in the plugin definition.

I've tried to highlight where I think we have difficulties with @todo's.

Log in or register to post comments

Comment #4

dawehner

German

commented 24 July 2015 at 12:56

Mhh tricky is real life.

+++ b/core/lib/Drupal/Core/Entity/Plugin/DataType/Deriver/EntityDeriver.php
@@ -90,6 +90,7 @@ public function getDerivativeDefinitions($base_plugin_definition) {
+            // @todo not sure
             'label' => $bundle_info['label'],

mhhh tricky one ... given that bundles are coming from config entities .. in order words this is an examples where the information is better cached per langcode

+++ b/core/modules/block_content/src/Plugin/Derivative/BlockContent.php
@@ -52,6 +52,7 @@ public function getDerivativeDefinitions($base_plugin_definition) {
+      // @todo what to do about this?
       $this->derivatives[$block_content->uuid()]['admin_label'] = $block_content->label();

so this would be content entity translated, mhhh

+++ b/core/modules/field_ui/src/Plugin/Derivative/FieldUiLocalTask.php
@@ -145,6 +146,7 @@ public function getDerivativeDefinitions($base_plugin_definition) {
+            // @todo what to do?
             'title' => $form_mode_info['label'],

Form mode is again coming from a config entity