Problem/Motivation

Our coding standards specify that switch statements should have blank lines between groups of cases. UpdateModuleHandler doesn't, and is hard to read.

Proposed resolution

Add blank lines after each return within the switch.

CommentFileSizeAuthor
update-module-handler-whitespace.patch1.35 KBxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Related issues: +#2168011: Remove all 7.x to 8.x update hooks and disallow updates from the previous major version
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: +Novice

Also, good patch for a novice to review. Apply the patch locally and confirm that the switch statement now matches documented coding standards. :)

StephaneQ’s picture

StephaneQ
Primary language French
Location Paris 🇫🇷
CreditAttribution: StephaneQ commented
Status: Needs review » Reviewed & tested by the community

Looks good to me :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.