Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 views-core-2003280-6.patch2.93 KBSpartyDan
#2 drupal-rename-set-limit-2003280-2.patch3.03 KBkenianbei

Comments

kenianbei’s picture

kenianbei commented
Assigned: Unassigned » kenianbei
kenianbei’s picture

kenianbei commented
Status: Active » Needs review
StatusFileSize
new drupal-rename-set-limit-2003280-2.patch3.03 KB

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-rename-set-limit-2003280-2.patch, failed testing.

connorwk’s picture

connorwk commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#2: drupal-rename-set-limit-2003280-2.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/QueryPluginBase.phpundefined
@@ -99,7 +99,7 @@ public function summaryTitle() {
+  function setLimit($limit) {

Add public access modifier in front of the function to adhere to the new OOP standards.

All occurrences have been replaced, so the corrected patch should then be RTBC.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new views-core-2003280-6.patch2.93 KB

Added public access modifier in front of the function to adhere to the new OOP standards.

Re-rolled.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

Apart from a minor issue with a leftover comment:

core/modules/views/lib/Drupal/views/Tests/Plugin/QueryTest.php, line 84:
$this->assertEqual($view->query->getLimit(), $rand_number, 'set_limit adapts the amount of items.');

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed b74991a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.