Files: 
CommentFileSizeAuthor
#6 views-core-2003280-6.patch2.93 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 56,056 pass(es).
[ View ]
#2 drupal-rename-set-limit-2003280-2.patch3.03 KBkenianbei
PASSED: [[SimpleTest]]: [MySQL] 55,868 pass(es).
[ View ]

Comments

kenianbei’s picture

Assigned:Unassigned» kenianbei
kenianbei’s picture

Status:Active» Needs review
StatusFileSize
new3.03 KB
PASSED: [[SimpleTest]]: [MySQL] 55,868 pass(es).
[ View ]

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, drupal-rename-set-limit-2003280-2.patch, failed testing.

connork-dupe’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC
oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/QueryPluginBase.phpundefined
@@ -99,7 +99,7 @@ public function summaryTitle() {
+  function setLimit($limit) {

Add public access modifier in front of the function to adhere to the new OOP standards.

All occurrences have been replaced, so the corrected patch should then be RTBC.

SpartyDan’s picture

Status:Needs work» Needs review
StatusFileSize
new2.93 KB
PASSED: [[SimpleTest]]: [MySQL] 56,056 pass(es).
[ View ]

Added public access modifier in front of the function to adhere to the new OOP standards.

Re-rolled.

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Apart from a minor issue with a leftover comment:

core/modules/views/lib/Drupal/views/Tests/Plugin/QueryTest.php, line 84:
$this->assertEqual($view->query->getLimit(), $rand_number, 'set_limit adapts the amount of items.');

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed b74991a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.