Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#7 views-core-rename-element_classes-2002468-07.patch1.72 KBSpartyDan
#4 rename_method_elementClasses-2002468-04.patch1.71 KBFredericoT
#2 0001-changing-element_classes-to-camelcase.patch2.1 KBmikedotexe

Comments

mikedotexe’s picture

mikedotexe commented
Assigned: Unassigned » mikedotexe

Working on this in Portland as a first patch with the mentors provided here

mikedotexe’s picture

mikedotexe commented
Status: Active » Closed (fixed)
StatusFileSize
new 0001-changing-element_classes-to-camelcase.patch2.1 KB

There were only 3 changes to make, so I'm marking it as fixed

oenie’s picture

oenie commented
Status: Closed (fixed) » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -287,7 +287,7 @@ function get_elements() {
+  function elementClasses($row_index = NULL) {

Add public access modifier in front of the function to adher to the new OOP standards.

FredericoT’s picture

FredericoT commented
Status: Needs work » Needs review
StatusFileSize
new rename_method_elementClasses-2002468-04.patch1.71 KB
oenie’s picture

oenie commented

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

oenie’s picture

oenie commented
Status: Needs review » Needs work

Hate to do this ... Unfortunately we need a reroll, the patch doesn't apply anymore.

SpartyDan’s picture

SpartyDan commented
Assigned: mikedotexe » Unassigned
Status: Needs work » Needs review
StatusFileSize
new views-core-rename-element_classes-2002468-07.patch1.72 KB

re-roll

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect, there are non other instances available.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed cd486a6 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.