Closed (works as designed)
Project:
Role Export
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
8 Apr 2013 at 19:35 UTC
Updated:
26 Nov 2013 at 21:46 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
deviantintegral commentedTada! Also, this patch statically caches role loading to save a few DB queries per request.
Comment #2
klausiData types are missing in the docs, see http://drupal.org/node/1354#param
Instead of looping over all roles you should calculate the rid and access the roles array directly with rid as key.
Comment #3
deviantintegral commentedImplements both of the suggestions from #2.
Comment #4
klausithe data type should be "object" in case of stdClass.
why do we need to load all roles here? Just calculate the rid and then call user_role_load()?
So I don't think we need the caching for role_export_roles().
Comment #5
Steven Brown commentedSince there has been no response to the issue for going forward and I agree with klausi in #4 comment, I am changing status.