Description

This project provides an interface to create contacts and store as phone book. You can add and view contacts on the same page.
You can edit the contacts and delete the contacts without page refresh.
Pager is implemented to view the contacts in a organized manner.
you can search the contact with a customized search-box.

Sandbox Project Link

http://drupal.org/sandbox/manishkumarshr/1645334

Git Repository Link

http://git.drupal.org/sandbox/manishkumarshr/1645334.git

Drupal Version

7.x

CommentFileSizeAuthor
#10 README.txt726 bytesdrupaldrop
#6 contact book.txt16.69 KBsaitanay
#1 pareview-codesniffer.txt55.35 KBKrisBulman
screenshot3.jpg56.33 KBmanish.kumar

Comments

KrisBulman’s picture

KrisBulman commented
StatusFileSize
new pareview-codesniffer.txt55.35 KB

The git link you posted is wrong, it should be http://git.drupal.org/sandbox/manishkumarshr/1645334.git

Initial automated review:

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Review of the master branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

KrisBulman’s picture

KrisBulman commented
Status: Needs review » Needs work
manish.kumar’s picture

manish.kumar commented

Thanks Kris for you review. I will work on these items and update.

-Manish :)

manish.kumar’s picture

manish.kumar commented

Thanks Kris, for your review. I will work on the list and update.

-Manish :)

manish.kumar’s picture

manish.kumar commented
Issue summary: View changes

Added Git repository link.

manish.kumar’s picture

manish.kumar commented
Status: Needs work » Needs review

HI, I have updated the codes and have tested the coding standard with coder module. Please review the codes.

Thanks
-Manish :)

saitanay’s picture

saitanay commented
Status: Needs review » Needs work
StatusFileSize
new contact book.txt16.69 KB

There seems to be a huge work to be done yet on the styling part of the code

The list is pretty long,. so i am attaching the text file here.

Also you might have to delete the 7.x-1.0 branch

Once fixed, re-run the automated review @ http://ventral.org/pareview/httpgitdrupalorgsandboxmanishkumarshr1645334git

This would help you check the styling issues.

Best
Tanay

manish.kumar’s picture

manish.kumar commented

Hi Tanay,

Thanks for you review. Actually the issues that have been pointed out were resolved earlier in the 7.x-1.0 branch but were not reflected in master branch. I have updated both the branches with lots of changes.

I have run the coder module for this project and have fixed the styling and coding standard issues.

Please spend some time to look at the stuffs again.

Thanks
-Manish :)

manish.kumar’s picture

manish.kumar commented
Status: Needs work » Needs review
manish.kumar’s picture

manish.kumar commented

Hi,

Modifications Made :

1. Deleted 7.x-1.0 branch, created 7.x-1.x
2. Cleaned up master branch.
3. Styling fixes done.
4. Ran automated review. http://ventral.org/pareview/httpgitdrupalorgsandboxmanishkumarshr1645334git

Please review again.

Thanks
-Manish :)

drupaldrop’s picture

drupaldrop commented
StatusFileSize
new README.txt726 bytes

Hello Manish,

  • In README.txt file the summary needs to be improved, I did some changes regarding the content layout please find the attached README.txt.
  • On the admin configuration page the description of the module is missing.
  • In the documentation please mention about how to create a contact. Because as a first time user I didn't found how to create a contact.
  • Add a help text under the field "Default country phone code" on the module configuration page.
  • In the .info file specify the path of the css and js files

Thanks
Akash

manish.kumar’s picture

manish.kumar commented

Hi Akash,

Thanks for you time and valuable review.

I have made modifications that you pointed out.

-improved README.txt
-On the admin configuration page the added description of the module.
-In the documentation, described how to create a new contact.
-Added a help text under the field "Default country phone code" on the module configuration page.

Please have a look and let me know if other modification is required.

Thanks
-Manish :)

bogeyman’s picture

bogeyman commented

Hello,

I think your project page should contain more information and description about the project, please read the Tips for a great project page to turn your project page into a great one. :)

dev001’s picture

dev001 commented
Status: Needs review » Needs work

pareview: found lots of issues, you can see it here:http://ventral.org/pareview/httpgitdrupalorgsandboxmanishkumarshr1645334git

Manual review:
1. in file includes/admin.inc
'#default_value' => variable_get('default_county_phone_code', ''),
in variable_get() function should have default value, it should not be empty.
2. blank line present in contact_book.info
3. Functions that are hooks have to be commented with
/**
* Implements hook_HOOKNAME().
*
* What your doing with it.
*/

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Update git repository link.