Once all of the recipes that will be available in the UI are committed, we should review the titles and descriptions to ensure they are consistent and clear.

Issue fork drupal_cms-3489421

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pameeela created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » pameeela
Status: Postponed » Active
Issue tags: +stable blocker

The list of recipes for 1.0.0 has been finalized with the release of 1.0.0-rc1, so this is both unblocked, and probably a stable blocker.

voj made their first commit to this issue’s fork.

voj opened merge request !301

voj’s picture

voj commented

Moved the orders of description 2nd to the title for consistency.
Removed unnecessary single quotes.

pameeela’s picture

pameeela commented
Status: Active » Needs work

Thanks, but the intention is to review the title and description content, not the formatting of the yaml. Suggestions are welcome but this is ultimately a product thing so that's why it's assigned to me :)

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: -stable blocker +Drupal CMS stable release blocker

pameeela opened merge request !356

pameeela changed the visibility of the branch review-recipe to hidden.

pameeela’s picture

pameeela commented
Status: Needs work » Needs review

I'm not overly thrilled with all of these, but I think it'll do for now to unblock :)

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Needs work

One suggestion, one question/yellow flag.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

One more point here -- the new descriptions should also be updated in the composer.json files.

pameeela’s picture

pameeela commented

Done, that's a bit annoying as they are repeated manually in a few places!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Reviewed & tested by the community

That's a great point -- we might be able to automate it in the ddev tag script. Worth looking into for sure!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: pameeela » Unassigned
Status: Reviewed & tested by the community » Fixed

Personally, I like these new descriptions quite a bit. They're concise and descriptive. But, we can always revisit. Merged into 1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pameeela closed merge request !301