Been battling for a couple days now to get 2.x working and thought i finally had it; but i have very latest -dev so possibly this issue is a very recent one.
structure is very simple:
- group node type: Building
group: Building 1
Building 1 members:
- badmin1 in role: building administrator
- op1 no roles assigned
- also uid = 1 = admin (not a member)
http://screencast.com/t/aI0uCSW9
admin, badmin1, op1 can all see Building 1 teaser at /node
admin, badmin1 can see Building 1 node view
op1 gets wsod for Building 1 node view
this all worked fine in 1.x but haven't gotten a version of 2.x up to the point where i could verify this used to work in 2.x
my guess would be something to do with recent changes to remove member, non-member roles from group ui (and possibly other places besides the ui)
i agree that concept of non-member doesn't make any sense; but not sure why member would be removed. should this not possibly be similar to the setup for the admin role where a role(s) needs to be defined as be assigned to newly added members?
Comments
Comment #1
liquidcms commentedwsod is caused by:
"call to undefined method EntityValueWrapper:entityAccess()" at og_ui.module, line 626
Comment #2
amitaibuIs it on a clean installation?
Comment #3
liquidcms commentedlol.. nope.. it was on a "reasonably clean" install.. my 5th so far.. but i broke down and deleted db and started from scratch and sure enough it is all working now.. :)
hopefully i don't need to redo sites from scratch each time og is changed a little; but maybe still was something lingering in db from 1.x to 2.x (although thought i had redone db from scratch when deciding to switch to 2.x)
thanks for all your work on this.. really should have a donate page from this project.. :)
Comment #4
azinck commentedAnyone have any tips here? I can confirm that I don't see the problem configuring a group on a fresh DB, but on my "built" database I've not been able to fix this problem. If I configure the display mode for the group node not to output the group field in the "OG Subscribe link" format then I can get around the problem, but that's not really a fix.
Comment #5
azinck commentedIs there any reason not to put a
break;on line 618 of og_ui.module? This appears to, at least superficially, fix it for me. That said, I'm not yet sure why my "clean" db doesn't seem affected by the issue.Comment #6
azinck commentedAh, I see the problem. You get the bug if you're a member of the group but don't have the "Unsubscribe from group" privilege. As far as I can tell the fix to this is adding break as per #5.
Comment #7
azinck commentedComment #8
checker commentedIn current dev it's line 653. After adding "break;" the fatal error is gone. But I don't know if there are new problems because of this "break;" ...
Comment #9
azinck commentedThe break is appropriate, as far as I can tell. There should be no reason to "fall into" the next switch case. I think it's a genuine bug.
Comment #10
amitaibuBefore adding a break, let's understand why it fails -- can someone please debug and see why it doesn't return before empty or with the element?
Comment #11
azinck commented@Amitaibu:
The problem occurs when your permissions are set to not allow members to remove themselves.
So we pass the check on line 574, but not the one on line 575. So we jump down to line 643 where we also fail that check (the links array hasn't gotten set)...then we fall into the next case without ever having returned anything. All line #'s refer to latest dev here: http://drupalcode.org/project/og.git/blob/refs/heads/7.x-2.x:/og_ui/og_u...
Comment #12
amitaibuThanks azinck, committed a
break;