Git errors:
- There is still a master branch, make sure to set the correct default branch: https://www.drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in https://www.drupal.org/node/1127732
Review of the 7.x-1.x branch (commit e18d7f1):
- Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
- DrupalPractice has found some issues with your code, but could be false positives.
FILE: ...eview/pareview_temp/views/plugins/views_plugin_style_entity_pager.inc
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
13 | WARNING | Class name must be prefixed with the project name
| | "EntityPager"
---------------------------------------------------------------------------
FILE: ...r/www/drupal-7-pareview/pareview_temp/includes/entity_pager_setup.inc
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
34 | WARNING | There must be no blank line following an inline comment
---------------------------------------------------------------------------
FILE: .../www/drupal-7-pareview/pareview_temp/includes/entity_pager_advice.inc
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
27 | WARNING | There must be no blank line following an inline comment
---------------------------------------------------------------------------
FILE: ...var/www/drupal-7-pareview/pareview_temp/includes/entity_pager_out.inc
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------
32 | WARNING | There must be no blank line following an inline comment
109 | WARNING | There must be no blank line following an inline comment
111 | WARNING | There must be no blank line following an inline comment
176 | WARNING | There must be no blank line following an inline comment
180 | WARNING | Unused variable $options.
---------------------------------------------------------------------------
Time: 126ms; Memory: 6Mb
- No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
FILE: ...eview/pareview_temp/views/plugins/views_plugin_style_entity_pager.inc
---------------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 16 LINES
---------------------------------------------------------------------------
13 | ERROR | [ ] Class name must begin with a capital letter
13 | ERROR | [ ] Class name must use UpperCamel naming without
| | underscores
18 | ERROR | [ ] Visibility must be declared on method "render"
35 | ERROR | [ ] Missing parameter comment
35 | ERROR | [ ] Missing parameter type
36 | ERROR | [ ] Missing parameter comment
36 | ERROR | [ ] Missing parameter type
38 | ERROR | [ ] Method name
| | "views_plugin_style_entity_pager::options_form" is not
| | in lowerCamel format
38 | ERROR | [ ] Visibility must be declared on method "options_form"
59 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
69 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
77 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
89 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
97 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
106 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
109 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
119 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
120 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
128 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
129 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
FILE: /var/www/drupal-7-pareview/pareview_temp/entity_pager.module
---------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 3 LINES
---------------------------------------------------------------------------
17 | ERROR | String concat is not required here; use a single string
| | instead
42 | WARNING | Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
59 | ERROR | Missing parameter comment
59 | ERROR | Missing parameter type
---------------------------------------------------------------------------
FILE: ...r/www/drupal-7-pareview/pareview_temp/includes/entity_pager_setup.inc
---------------------------------------------------------------------------
FOUND 55 ERRORS AFFECTING 39 LINES
---------------------------------------------------------------------------
29 | ERROR | [ ] Class name must begin with a capital letter
29 | ERROR | [ ] Class name must use UpperCamel naming without
| | underscores
31 | ERROR | [x] Comments may not appear after statements
32 | ERROR | [x] Comments may not appear after statements
33 | ERROR | [ ] Class property $entity_info should use lowerCamel
| | naming without underscores
33 | ERROR | [x] Comments may not appear after statements
34 | ERROR | [x] Comments may not appear after statements
39 | ERROR | [ ] Missing parameter comment
39 | ERROR | [ ] Missing parameter type
52 | ERROR | [ ] Missing parameter comment
52 | ERROR | [ ] Missing parameter type
53 | ERROR | [ ] Missing parameter comment
53 | ERROR | [ ] Missing parameter type
62 | ERROR | [ ] Missing parameter comment
62 | ERROR | [ ] Missing parameter type
64 | ERROR | [ ] Return comment must be on the next line
79 | ERROR | [ ] Missing parameter comment
79 | ERROR | [ ] Missing parameter type
90 | ERROR | [ ] @return data type must not contain "$"
90 | ERROR | [ ] Return comment must be on the next line
99 | ERROR | [ ] Missing parameter comment
99 | ERROR | [ ] Missing parameter type
109 | ERROR | [ ] Return comment must be on the next line
124 | ERROR | [ ] Missing parameter comment
124 | ERROR | [ ] Missing parameter type
126 | ERROR | [ ] Return comment must be on the next line
140 | ERROR | [ ] Missing parameter comment
140 | ERROR | [ ] Missing parameter type
142 | ERROR | [ ] Return comment must be on the next line
153 | ERROR | [ ] Return comment must be on the next line
167 | ERROR | [ ] Return comment must be on the next line
178 | ERROR | [ ] Return comment must be on the next line
193 | ERROR | [ ] Missing parameter comment
193 | ERROR | [ ] Missing parameter type
204 | ERROR | [ ] Missing parameter comment
204 | ERROR | [ ] Missing parameter type
215 | ERROR | [ ] Return comment must be on the next line
227 | ERROR | [ ] Return comment must be on the next line
246 | ERROR | [ ] Return comment must be on the next line
258 | ERROR | [x] Comments may not appear after statements
263 | ERROR | [x] Doc comment short description must end with a full stop
271 | ERROR | [ ] Missing parameter comment
271 | ERROR | [ ] Missing parameter type
298 | ERROR | [ ] Missing parameter comment
298 | ERROR | [ ] Missing parameter type
300 | ERROR | [ ] Return comment must be on the next line
328 | ERROR | [x] Doc comment long description must end with a full stop
330 | ERROR | [ ] Return comment must be on the next line
350 | ERROR | [ ] Missing parameter comment
350 | ERROR | [ ] Missing parameter type
364 | ERROR | [ ] Missing parameter comment
366 | ERROR | [ ] Return comment must be on the next line
368 | ERROR | [ ] Type hint "null" missing for $field
372 | ERROR | [x] Comments may not appear after statements
375 | ERROR | [x] Comments may not appear after statements
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
FILE: /var/www/drupal-7-pareview/pareview_temp/includes/entity_pager.inc
---------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------
29 | ERROR | [ ] Class name must begin with a capital letter
29 | ERROR | [ ] Class name must use UpperCamel naming without
| | underscores
33 | ERROR | [x] Missing function doc comment
59 | ERROR | [ ] Missing parameter comment
61 | ERROR | [ ] Return comment must be on the next line
63 | ERROR | [ ] Type hint "null" missing for $field
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
FILE: .../www/drupal-7-pareview/pareview_temp/includes/entity_pager_advice.inc
---------------------------------------------------------------------------
FOUND 17 ERRORS AFFECTING 12 LINES
---------------------------------------------------------------------------
14 | ERROR | [ ] Class name must begin with a capital letter
14 | ERROR | [ ] Class name must use UpperCamel naming without
| | underscores
22 | ERROR | [ ] Return comment must be on the next line
24 | ERROR | [ ] Private method name
| | "entity_pager_advice::check_performance" is not in
| | lowerCamel format
27 | ERROR | [x] Comments may not appear after statements
38 | ERROR | [ ] Return comment must be on the next line
40 | ERROR | [ ] Private method name
| | "entity_pager_advice::views_caching_is_used" is not in
| | lowerCamel format
58 | ERROR | [ ] Missing parameter comment
58 | ERROR | [ ] Missing parameter type
59 | ERROR | [ ] Missing parameter comment
59 | ERROR | [ ] Missing parameter type
61 | ERROR | [ ] Protected method name
| | "entity_pager_advice::run_advice_logic" is not in
| | lowerCamel format
88 | ERROR | [ ] Missing parameter comment
88 | ERROR | [ ] Missing parameter type
89 | ERROR | [ ] Missing parameter comment
89 | ERROR | [ ] Missing parameter type
107 | ERROR | [x] Case breaking statements must be followed by a single
| | blank line
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
FILE: ...var/www/drupal-7-pareview/pareview_temp/includes/entity_pager_out.inc
---------------------------------------------------------------------------
FOUND 42 ERRORS AFFECTING 30 LINES
---------------------------------------------------------------------------
18 | ERROR | [ ] Class name must begin with a capital letter
18 | ERROR | [ ] Class name must use UpperCamel naming without
| | underscores
26 | ERROR | [ ] Return comment must be on the next line
28 | ERROR | [ ] Public method name "entity_pager_out::get_entity_pager"
| | is not in lowerCamel format
32 | ERROR | [x] Comments may not appear after statements
62 | ERROR | [ ] Missing parameter comment
62 | ERROR | [ ] Missing parameter type
63 | ERROR | [ ] Missing parameter comment
63 | ERROR | [ ] Missing parameter type
64 | ERROR | [ ] Missing parameter comment
64 | ERROR | [ ] Missing parameter type
65 | ERROR | [ ] Missing parameter comment
65 | ERROR | [ ] Missing parameter type
67 | ERROR | [ ] Private method name "entity_pager_out::token_link" is
| | not in lowerCamel format
95 | ERROR | [ ] Missing parameter comment
95 | ERROR | [ ] Missing parameter type
96 | ERROR | [ ] Missing parameter comment
96 | ERROR | [ ] Missing parameter type
97 | ERROR | [ ] Missing parameter comment
97 | ERROR | [ ] Missing parameter type
99 | ERROR | [ ] Return comment must be on the next line
101 | ERROR | [ ] Protected method name
| | "entity_pager_out::entity_ref_url_from_token" is not in
| | lowerCamel format
109 | ERROR | [x] Comments may not appear after statements
111 | ERROR | [x] Comments may not appear after statements
132 | ERROR | [ ] Missing parameter comment
132 | ERROR | [ ] Missing parameter type
133 | ERROR | [ ] Missing parameter comment
133 | ERROR | [ ] Missing parameter type
135 | ERROR | [ ] Return comment must be on the next line
137 | ERROR | [ ] Private method name
| | "entity_pager_out::calculate_next_all_prev_values_from_view"
| | is not in lowerCamel format
143 | ERROR | [x] Comments may not appear after statements
144 | ERROR | [x] Comments may not appear after statements
176 | ERROR | [x] Comments may not appear after statements
193 | ERROR | [x] Comments may not appear after statements
199 | ERROR | [ ] Function return type is not void, but function is
| | returning void here
199 | ERROR | [x] Comments may not appear after statements
224 | ERROR | [x] Doc comment short description must end with a full stop
230 | ERROR | [ ] Missing parameter comment
230 | ERROR | [ ] Missing parameter type
232 | ERROR | [ ] Return comment must be on the next line
239 | ERROR | [x] Comments may not appear after statements
240 | ERROR | [x] Comments may not appear after statements
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
FILE: /var/www/drupal-7-pareview/pareview_temp/entity_pager.info
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
5 | ERROR | Drupal 7 core already requires PHP 5.2
----------------------------------------------------------------------
Time: 276ms; Memory: 8.25Mb
Source: http://pareview.sh/ - PAReview.sh online service