Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Plugins, annotations, PluginManagers, oh my!
Comment | File | Size | Author |
---|---|---|---|
#8 | 1950726_8.patch | 10.19 KB | chx |
#8 | diffdiff.txt | 2.31 KB | chx |
#4 | 1950726_4.patch | 10.47 KB | chx |
#4 | diffdiff.txt | 3.17 KB | chx |
archiver_info_shiny_edition.patch | 10.63 KB | chx | |
Comments
Comment #1
EclipseGc CreditAttribution: EclipseGc commentedLooks good to me.
Eclipse
Comment #2
xjmarchiver_info_shiny_edition.patch queued for re-testing.
Comment #3
tim.plunkettBit of nitpicking, my apologies. Functionally this is RTBC, the conversion looks awesome.
Here you change the variable name away from $filepath, but both Components refer to it as such. Why not leave it?
Contains \Drupal\...
and there is an extra blank line
Missing a docblock
s/it's/its
::createInstance, not \
::getInstance()
Contains \Drupal\
Comment #4
chx CreditAttribution: chx commentedComment #5
tim.plunkettThanks!
Comment #6
catch#4: 1950726_4.patch queued for re-testing.
Comment #8
chx CreditAttribution: chx commentedKeeping up with HEAD.
Comment #9
webchickOKie doke!
Committed and pushed to 8.x. Thanks!
Comment #11
tim.plunkettThis needs a change notice. Also see #1987298: Shorten directory structure and PSR-0 namespacing for plugins for the updated path.
Comment #12
chx CreditAttribution: chx commentedI am not writing this right now
Comment #13
nielsonm CreditAttribution: nielsonm commentedI created the change record. https://drupal.org/node/2003376
Comment #14
jibranSome before and after will certainly help so please add that and name spaces as well. Thanks for the change notice.
Comment #15
chx CreditAttribution: chx commentedI took the notice and https://drupal.org/node/1993056, merged them and this is now done.
Comment #16
jibranThanks @chx.
Comment #17
jibranReverting title.