CTools - Allow ctools_ajax_page_preprocess to not be ran & added documentation to includes/ajax.inc

+  // If advagg is enabled this happens in ctools_advagg_js_header_footer_alter()
+  // and ctools_advagg_css_pre_alter().
+  if (module_exists('advagg') && variable_get('advagg_enabled', defined('ADVAGG_ENABLED'))) {
+    return;
+  }

Can we do something a little bit smarter than this? Is there an advagg hook that runs prior to the page preprocess, for example, that I could just set a variable rather than doing a module_exists? It would be nicer if this were more generic since there could be other reasons to avoid ctools doing this and possibly other modules could set that.

I think I prefer the min but I will listen to discussion about whether CTools should support AdvAgg or the reverse. Obviously my typical stance is that I try to push support out, but AdvAgg ties so closely to this that I can see supporting it in CTools.

That said, variable_get() is probably bad -- since variable_set() will cause a cache write every time it's called. A ctools_static() is probably a better choice than a variable_set() since the latter also persists and I'd rather do this on a per page load basis.

I totally don't mind modifying ctools_process_js_files but I'm curious if $contrib is using it. I would be more comfortable if we changed it in such a way as to not break the function signature, by adding an extra $scripts = NULL argument

if (empty($scripts)) {
  // existing behavior
}

That is the least invasive change and wont' cause someone ELSE using this to break.

I think we're almost done.

Let's add a function that sets the static so that we can document what the static does and why one would use it easily. How about...ctools_skip_js_aggregation($value = FALSE);

+  $run_hook = &ctools_static(__FUNCTION__, TRUE);
+  $run_hook = $value;
+}
+
+/**
+ * Implement hook_preprocess_page. Process variables for page.tpl.php
+ *
+ * @param $variables
+ *   The existing theme data structure.
+ */
 function ctools_ajax_page_preprocess(&$variables) {
+  // See if we will be running this hook.
+  $run_hook = &ctools_static(__FUNCTION__, TRUE);

They can't both use __FUNCTION__ -- that makes them separate variables.

Sorry, have been stuck with client work and haven't had much free times for the issue queues the last 2 weeks.

#9 patch works for me with ctools + advagg
Thanks Mike!

2 questions -

- Is this only for 6.x-1.x-dev or can this be used with the stable release of ctools
- Is this for panels 2 or 3 or does that not matter '

Cause I applied the patch on #9 and I am still returning the same problems with ajax

I am running panels 2 and ctools 6.x-1.8

thanks!

@mikeytown2
weird now its working I think I just needed to clear the cache or something, I will let you know if I experience any thing out of the ordinary thanks!
#9 worked for me!

Trying it out because I was having trouble with advagg and ajax flags, it helps a little but it isn't perfect. The throbber and the "you flagged this!" text doesn't show up and flagging occasionally doesn't work, haven't figured out what breaks it yet.

Nevermind, I think my problem has to do with the Highslide modal I'm opening the flags up in.

I have an issue with ctools_ajax_render(). Together with AdvAgg it outputs unprocessed system.css which breaks the theme after an ajax request.
Should this patch cover that too, Mike ? The patch doesn't fix the issue with CTools dev snapshot from 2010-10-16.

@mikeytown2
After ajax request unprocessed (I mean non-aggregated) system.css styles override aggregated css styles, so design breaks (a little). Ofcourse I expect design not to break with ajax. Looks like system.css styles should be already inside the aggregated files.
You can test it with my Devel Query Ajax module which uses CTools.

I've just updated ctools and this patch still works flawlessly.

The patch in #9 solve my problem:
With Advagg (6.x-1.9) + Vote Up/Down (6.x-3.2), after voting, the layout breaks in a horrible way...

Thanks!

Looks good, fixed!