Support custom success callbacks in ahah.js

I understand where this patch is coming from and why we need it, however I'm not sure it's the right approach. We've already introduced "#ahah['callback']" (see #360128: Security fix for simplified AHAH callbacks), so having something called "success_callback" could be confusing when one of them refers to a JavaScript callback and the other one refers to a PHP callback.

Since this patch is intended to provide functionality only in the JavaScript layer, it'd make sense to make the solution purely JavaScript based. We've already setup AHAH objects, but unfortunately they're not actually available anywhere.

This small patch simply makes the AHAH object public, so you can override any of the methods (such as beforeSubmit, success, and error).

An example for a button with the ID "edit-more":

Drupal.ahah['edit-more'].success = function(response, status) {
  alert('Custom callback executed.');
};

To keep with spirit of sticking to the domain of javascript, I added the following to ahah.js after applying patch #2.

Add this code in Drupal.ahah.prototype.success

  if (new_content.parents('html').length > 0) {
    Drupal.attachBehaviors(new_content);
  }
+ if (typeof this.success_callback == "function") {
+  this.success_callback(response, status);
+ }
  Drupal.unfreezeHeight();  

This allows for:

Drupal.ahah['edit-submit'].success_callback = function(response, status) {
  // code goes here.		  
};

without by-passing the default ahah success callback.

subscribing

Re-roll against HEAD (actually against the latest dev release, because I've no access to cvs from here).

Ah, diffed from wrong directory. No it should pass.

Ok, now for real.

Patch doesn't break any functionality and adds a lot of needed flexibility. We're doing this same approach in Drupal.tableDrag[keyName], and it's been working well for the Drupal 6 release cycle. I applied the patch and tested the following:

- Table drag
- CCK "more" button
- Poll "more" button
- Resizeable textareas

This patch doesn't change any functional code, it just moves it to a separate function.

Committed to CVS HEAD. Thanks.

Awesome! Thanks Dries.

@Dries: Is this patch available in version 6.19?
I downloaded Drupal's 6.19 version from drupal.org yet I had to apply this patch.

apply #2 and #3 work nice on 6.20

#13: 396466_ahah_public-13.patch queued for re-testing.

#2: drupal_ahah_objects.patch queued for re-testing.

bmhaskar changed this to 6.20 as a bug report. Spent a bit of time trying to get this working on 6.x before I realized this is intended for 7. Can someone confirm and update the status / close this thing?

Well, that's not going to make it to 6 and the functionality is already available in 7.x

I'll just mark it fixed to let people read it just in case.

ahah_success_callbacks_frh.patch queued for re-testing.

i have a form with cck filefield and i want to trigger ajaxtrigger after file was successfully uploaded to server.

all what i need is event in my js, how i can do it without changing ahah.js ?

Support requests are neither major nor critical.