Hiding either of the off-canvas regions in a subtheme results in PHP warnings because the hook_theme_suggestions_alter() implementation assumes that the regions exist.

Notice: Undefined index: left_off_canvas in zurb_foundation_theme_suggestions_alter() (line 11 of themes/contrib/zurb_foundation/inc/theme.inc).

CommentFileSizeAuthor
#5 zurb_foundation-2773137-5.patch2.4 KBtim_dj
#3 zurb_foundation-2773137-3.patch2.39 KBgapple
#2 zurb_foundation-2773137-2.patch1017 bytesgapple

Comments

gapple created an issue. See original summary.

gapple’s picture

gapple
he/they
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new zurb_foundation-2773137-2.patch1017 bytes
gapple’s picture

gapple
he/they
Primary language English
commented
StatusFileSize
new zurb_foundation-2773137-3.patch2.39 KB

Another change for when menus are placed in an off-canvas region

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs review » Needs work

This looks good @gapple, but would you mind using underscores to separate variable words instead of camel casing? This will keep the patch consistent with the rest of the project.

tim_dj’s picture

tim_dj
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new zurb_foundation-2773137-5.patch2.4 KB

Working on this right now so might as well upload the fixed patch without camel casing.

bandanasharma’s picture

bandanasharma commented

#5 patch is apply successfully and variable camel casing is changed.

bandanasharma’s picture

bandanasharma commented
Status: Needs review » Reviewed & tested by the community

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Looks good to me, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.