Currently the included recipes allow for getting a zurb foundation sub-theme setup with almost no effort (which is awesome). A few more things that could stream line other next steps:

automatically set an admin theme to something other then zurb-foundation (like seven, could be a madlib)
set jquery_update for admin_theme to drupal default to avoid conflicts with the 1.10 requirement of zurb foundation

This could all be added after the existing as a "run clean up?" conditional statement. This way people could choose not to run it.

Also, make one of the keys in the conditional statement that currently exists marked as 'default'. This way if someone passes

drush cook zurb_foundation --y --env-sub=thing

It would automatically build without asking any questions (or going into an infinite loop as conditionals can do when run without a default).

CommentFileSizeAuthor
#2 zurb_foundation-recipe-improvements-2426695-3.patch4.89 KBbtopro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented

I would think you can just default the admin theme to Seven without asking, since ZF isn't necessarily built to be an admin theme out of the box.

I also think that yeah, it needs to default to 1.10 to work with F5, but default the backend to 1.7 so it is compatible with Drupal core and contrib (Views/Panels).

btopro’s picture

btopro CreditAttribution: btopro commented
Status: Active » Needs review
FileSize
zurb_foundation-recipe-improvements-2426695-3.patch4.89 KB

should resolve both suggestions

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented

btopro, can you point me in the direction of getting started with Drush recipes?

btopro’s picture

btopro CreditAttribution: btopro commented

https://www.drupal.org/project/drush_recipes

drush dl drush_recipes && drush cc drush && drush cook zurb_foundation

:)

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented

Looks good to me, committed.

  • kevinquillen committed 54c7ad4 on 7.x-5.x authored by btopro 
    Issue #2426695 by btopro: Recipe suggestions to stream line setup
kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.