Zen 7.x-6.x Theme defaults to Two Columns. The second side bar appears under the first sidebar resulting in a two column layout.
Here is the resulting css for "First" left side bar:
@media (min-width: 999px)
.layout-3col__left-sidebar, .layout-3col__first-left-sidebar, .layout-3col__second-left-sidebar {
clear: right;
float: right;
width: 33.33333%;
margin-right: 66.66667%;
margin-left: -100%;
}
Here is the resulting css for "Second" right side bar:
@media (min-width: 999px)
.layout-3col__left-sidebar, .layout-3col__first-left-sidebar, .layout-3col__second-left-sidebar {
clear: right;
float: right;
width: 33.33333%;
margin-right: 66.66667%;
margin-left: -100%;
}
And css for content:
@media (min-width: 999px)
.layout-3col__right-content {
float: left;
width: 66.66667%;
margin-left: 33.33333%;
margin-right: -100%;
}
I cannot see how one can get a 3 column layout from the above css?
Comment | File | Size | Author |
---|---|---|---|
#5 | theme_defaults_to_two_columns-2824485-5.patch | 5.51 KB | sl27257 |
Comments
Comment #2
vidit.anjaria CreditAttribution: vidit.anjaria as a volunteer and at Faichi Solutions Pvt Ltd for Faichi Solutions Pvt Ltd commentedHi @lperepol,
You are absolutely right. I think we should provide patch for this issue. But it will make too much changes in the core styles.css file.
Comment #3
sl27257Is anyone working on fixing this issue?
Comment #4
Phoenix48 CreditAttribution: Phoenix48 commentedI have the same problem. After a little research, i realised that the second sidebar is not the same thing as the right sidebar. I had wrongly assumed that the second sidebar was to the right. The second sidebar is in fact the second left sidebar and the right sidebar is what it is. I found references to the right sidebar in the style.css file in the zen/zen-internals/css folder but they don't seems to be in effect and don't show up as block anywhere. I hope someone better than me at coding will find the time to fix it.
Comment #5
sl27257Hi,
here is a patch that solves most of the problem. It is actually much easier then I thought...
The patch is towards the zen 7.x-6.4 as distributed, i.e. it shall be applied before the STARTERKIT is taken out and made into a sub-theme.
What is done is
The change in the _layout-3col.scss might introduce side effects in other implementations. If so a new style must be introduced for this case. Not too hard to do.
There is a "minor" problem when in tablet-mode (2-col mode) that should be looked into.
/Thomas
Comment #6
sl27257BTW, don't forget to
after you have applied the patch!
/Thomas
Comment #7
hans_dampfer CreditAttribution: hans_dampfer commentedIt´s a bit confusing with STARTERKIT region-namings:
sidebar_first
sidebar_second
left-sidebar
right-sidebar
first-left-sidebar
second-left-sidebar
In STARTERKIT.info.txt there are only the regions:
sidebar_first
sidebar_second
In the page.tpl.php these two regions are called:
$sidebar_first = render($page['sidebar_first']);
$sidebar_second = render($page['sidebar_second']);
In the STARTERKITs _layout-3col.scss there are the classes
&__left-sidebar
&__first-left-sidebar
&__second-left-sidebar
&__right-sidebar
So without the patch you have a second-left-sidebar.
With the patch you have a right-sidebar.
HANS
Comment #8
torgosPizzaThere's a patch here, so setting to Needs Review.
Comment #9
JohnAlbin