Problem/Motivation

As described in #2716773: [Meta] Convert 7.x-6.x Twig components to be Drupal 8-compatible, we need to convert the comment component from Zen 7.x-6.x to be compatible with Drupal 8.

Proposed resolution

The parent issue describes the general solution we need to use when converting a component.

We will need a comment.html.twig file and remove remains of comment-wrapper cos core one is great.

CommentFileSizeAuthor
#11 2724973-comment-11-m.patch9.58 KBandypost
#11 2724973-comment-11.patch12.05 KBandypost
#11 comment_wrapper.png137.87 KBandypost
#10 2724973-comment-8.patch10.86 KBandypost
#10 interdiff.txt3.45 KBandypost
#7 Selection_331.jpg223.59 KBHOG
#6 convert_comment-2724973-6.patch7.4 KBandriyun
#2 convert_comment-2724973-2.patch6.52 KBJimSmith
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JimSmith created an issue. See original summary.

JimSmith’s picture

JimSmith CreditAttribution: JimSmith as a volunteer and commented
Status: Active » Needs work
FileSize
convert_comment-2724973-2.patch6.52 KB

Here is a patch that provides a start. At this point it is incomplete and is throwing an error during Gulp compilation.

Error parsing twig template comment.twig:
TwigException: Expected end of array.
JimSmith’s picture

JimSmith CreditAttribution: JimSmith as a volunteer and commented
Assigned: JimSmith » Unassigned

I may be too tied up to work on this for now so I'm unassigning myself. If I can free up some time I will pick it up again or take another task. I just don't want to be a roadblock.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin for ImageX commented
Assigned: Unassigned » JohnAlbin

I'm starting on this now.

andriyun’s picture

andriyun CreditAttribution: andriyun at Skilld, Drupal Ukraine Community commented
Assigned: JohnAlbin » andriyun

I'm going to continue work with this issue after 5 months of silence :)

andriyun’s picture

andriyun CreditAttribution: andriyun at Skilld, Drupal Ukraine Community commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
convert_comment-2724973-6.patch7.4 KB
HOG’s picture

HOG CreditAttribution: HOG at Skilld, Drupal Ukraine Community commented
FileSize
Selection_331.jpg223.59 KB

Patch work ok for me.

+1 to RTBC

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Looks mostly clean and "core way" but this prevents to manage title within {{content}}

+++ b/STARTERKIT/components/components/comment/comment.twig
@@ -1,15 +1,53 @@
+    {{ user_picture }}
+    <p class="comment__submitted">{{ submitted }}</p>
...
+    {% if parent %}
+      <p class="parent visually-hidden">{{ parent }}</p>
+    {% endif %}
...
+    {{ permalink }}
...
+    {% if title %}
...
+      <h3{{ title_attributes }}>{{ title }}</h3>
...
+    {% endif %}

user picture is optional as well as submitted

Also it makes sense to find consensus on "rearrange" that users can make with field_ui manage display!

andriyun’s picture

andriyun CreditAttribution: andriyun at Skilld, Drupal Ukraine Community commented

Thank you for review.

@Andy I have used template from Classy core theme.
So we have the same abilities like we had now.

If you want add smth or improve need a bit more then few string in review comment.
Please elaborate your idea or propose more extended patch.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
interdiff.txt3.45 KB
2724973-comment-8.patch10.86 KB

First of all - kill remains of d7 for comment
Todo - convert comment wrapper to finished with component, ref #1962846: Use field instance name for header of comment list, drop comment-wrapper template

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue summary: View changes
FileSize
comment_wrapper.png137.87 KB
2724973-comment-11.patch12.05 KB
2724973-comment-11-m.patch9.58 KB

wrapper could be used from core

+++ /dev/null
@@ -1,52 +0,0 @@
-    <?php if ($unpublished): ?>
-      <mark class="watermark"><?php print t('Unpublished'); ?></mark>
-    <?php elseif ($preview): ?>
-      <mark class="watermark"><?php print t('Preview'); ?></mark>
-    <?php endif; ?>

looks watermark should be used because there's such component in
/STARTERKIT/components/components/watermark/watermark.twig

andriyun’s picture

andriyun CreditAttribution: andriyun at Skilld, Drupal Ukraine Community commented
Status: Needs review » Needs work