Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There is no help page for the module. It would be helpful if we implement help page.
Comment | File | Size | Author |
---|---|---|---|
#16 | 2862767-16.patch | 1.52 KB | harsha012 |
#13 | interdiff-10-13.txt | 1.29 KB | harsha012 |
#13 | 2862767-13.patch | 1.52 KB | harsha012 |
#10 | interdiff_6-10.txt | 470 bytes | dhruveshdtripathi |
#10 | implement_hook_help_for-2862767-10.patch | 1.52 KB | dhruveshdtripathi |
Comments
Comment #2
Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commentedComment #3
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedFollow Help Text standards https://www.drupal.org/docs/develop/documenting-your-project/help-text-standards
Uses section is not there.
Comment #4
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedWorking on it.
Comment #5
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedComment #6
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedMade changes according to standards. Interdiff added.
Comment #7
Aanal.addweb CreditAttribution: Aanal.addweb at AddWeb Solution Pvt. Ltd. commented@dhruveshdtripathi, Thanks for patch, it works well i checked it with simplytest.me. PFA
Comment #8
guschilds CreditAttribution: guschilds at Chromatic commentedThanks for the patch. A couple things:
require_once()
call at the top of the module like there is, that call should stay at the top. The addedyoutube_help()
should at least come after that call and beforeyoutube_menu()
.Thanks again!
Comment #9
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedAgreed! Working on that.
Comment #10
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedMoved hook_help section between require_once and hook_menu. About Drupal8. I'll be working on it after D7 gets committed. We'll move this issue to D8 after it gets committed to D7. Suggested me any other changes if needed.
Thanks!
Comment #11
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commentedComment #12
GoldLooking good. Just a few Drupal code standards to sort out and this looks done.
Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
The closing paragraph tag should not be in the t().
Translatable strings should not start or end with white space.
Comment #13
harsha012 CreditAttribution: harsha012 as a volunteer and at Red Crackle commentedComment #14
GoldAlmost there.
Lose the "of" and it's done.
Comment #15
GoldJust a note on Code Standards; The Coder module is very handy in checking these. It works from the website and can integrate into external tools like PHP CodeSniffer which, in turn, can integrate into your preferred code editor.
I find it very handy for this sort of thing.
This comment also tweaks the commit details a bit. I just read Commit messages - providing history and credit and noticed that the automated details get a little lost after multiple people start tweaking the patch.
Comment #16
harsha012 CreditAttribution: harsha012 as a volunteer and at Red Crackle commentedFixed the minor nit pick
Comment #17
Aanal.addweb CreditAttribution: Aanal.addweb at AddWeb Solution Pvt. Ltd. commented@harsha012, Thanks for Providing patch, Now all the errors are clear & your patch works correctly for me.
Comment #18
GoldIndeed, it is a minor nit pick. But they're called Standards for a reason. Automated tools can't really sit there and go "meh, not a big deal".
This looks good to me now too. +1 for RTBC.
@harsha012 thanks for your time on this. :)
Comment #19
imyaro CreditAttribution: imyaro at DrupalJedi commentedComment #21
imyaro CreditAttribution: imyaro at DrupalJedi commentedChanged a little and commited.