Follow-up to #2694359: Clean up code style issues in tests directory

FILE: ...docroot/modules/contrib/youtube/src/Form/YoutubeSettingsForm.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 23 | ERROR | [ ] Public method name "YoutubeSettingsForm::getFormID"
    |       |     is not in lowerCamel format
 95 | ERROR | [x] Array closing indentation error, expected 4 spaces
    |       |     but found 5
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...rib/youtube/src/Plugin/Field/FieldFormatter/YouTubeFormatter.php
----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 130 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 133 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 6
 133 | ERROR | [x] Closing brace indented incorrectly; expected 4
     |       |     spaces, found 6
 142 | ERROR | [x] There should be no white space after an opening
     |       |     "{"
 142 | ERROR | [x] There should be no white space before a closing
     |       |     "}"
 161 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...outube/src/Plugin/Field/FieldFormatter/YouTubeThumbFormatter.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
  12 | WARNING | [x] Unused use statement
 126 | ERROR   | [x] The closing brace for the class must have an
     |         |     empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../youtube/src/Plugin/Field/FieldFormatter/YouTubeUrlFormatter.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 109 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...dules/contrib/youtube/src/Plugin/Field/FieldType/YouTubeItem.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 33 | ERROR | [ ] Visibility must be declared on property
    |       |     "$propertyDefinitions"
 84 | ERROR | [x] The closing brace for the class must have an empty
    |       |     line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...tube.chromatic.is/docroot/modules/contrib/youtube/youtube.module
----------------------------------------------------------------------
FOUND 24 ERRORS AND 12 WARNINGS AFFECTING 28 LINES
----------------------------------------------------------------------
  13 | WARNING | [x] Unused use statement
  40 | ERROR   | [ ] Missing parameter type
  43 | ERROR   | [ ] Return comment must be on the next line
 211 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 260 | ERROR   | [ ] Missing parameter type
 262 | ERROR   | [ ] Missing parameter type
 264 | ERROR   | [ ] Missing parameter type
 297 | ERROR   | [ ] Missing parameter type
 379 | ERROR   | [ ] Missing parameter type
 381 | ERROR   | [ ] Missing parameter type
 403 | ERROR   | [ ] Function return type is not void, but function
     |         |     is returning void here
 415 | WARNING | [ ] Hook implementations should not duplicate @param
     |         |     documentation
 415 | ERROR   | [ ] Missing parameter type
 419 | WARNING | [ ] Hook implementations should not duplicate @param
     |         |     documentation
 419 | ERROR   | [ ] Missing parameter type
 421 | WARNING | [ ] Hook implementations should not duplicate @param
     |         |     documentation
 421 | ERROR   | [ ] Missing parameter type
 444 | ERROR   | [ ] Missing parameter type
 446 | ERROR   | [ ] Missing parameter type
 448 | ERROR   | [ ] Missing parameter type
 450 | ERROR   | [ ] Missing parameter type
 466 | WARNING | [ ] Hook implementations should not duplicate @param
     |         |     documentation
 466 | ERROR   | [ ] Missing parameter type
 476 | ERROR   | [x] Inline control structures are not allowed
 477 | ERROR   | [x] Inline control structures are not allowed
 479 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
     |         |     found 8
 479 | ERROR   | [x] There must be no space between the "array"
     |         |     keyword and the opening parenthesis
 482 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $field_name
 516 | WARNING | [ ] Hook implementations should not duplicate @param
     |         |     documentation
 516 | ERROR   | [ ] Missing parameter type
 520 | WARNING | [ ] Hook implementations should not duplicate @param
     |         |     documentation
 520 | ERROR   | [ ] Missing parameter type
 524 | WARNING | [ ] Hook implementations should not duplicate @param
     |         |     documentation
 527 | WARNING | [ ] Hook implementations should not duplicate @param
     |         |     documentation
 531 | WARNING | [ ] Hook implementations should not duplicate
     |         |     @return documentation
 531 | ERROR   | [ ] Return comment must be on the next line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 480ms; Memory: 13.25Mb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markdorison created an issue. See original summary.

markdorison’s picture

Status: Active » Needs review
FileSize
9.96 KB

guschilds’s picture

Status: Needs review » Fixed

Thanks, markdorison. This has been committed to the 8.x-1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.