I'm runing sonarqube in a project an this issue came as critical:
Invalid typeof comparison value
It apperas to be a typo on line 373 of jquery.tablesorter.js

Proposed resolution
Correct the typo

Issue fork xmlsitemap-3374965

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Carlitus created an issue.

Carlitus opened merge request !33

Carlitus closed merge request !33

Carlitus opened merge request !34

carlitus’s picture

carlitus commented

I think i've done something wrong. When i try to make the merge request i don't see any form to select the branch and i closed the merge request because it was made to 8 version.

A then i find a way to create another merge request to 7 branch.

And this MR seems ok:
https://git.drupalcode.org/project/xmlsitemap/-/merge_requests/34

poker10’s picture

poker10 commented

Thanks for working on this.

Do we need to fix this also in jquery.tablesorter.min.js? Because there is the same comparision used. Anyway it seems like a valid bug report, as in the oldest version of the library, I was able to find: https://github.com/Mottie/tablesorter/blame/v2.0.6/js/jquery.tablesorter.js , the comparision is !==.. The module is using 2.0.3 and I was able to find only 2.0.6 on github.

carlitus’s picture

carlitus commented

Hi,

I have made the same change in the js as in the min.js.

You say I should only have done it in the js?