The config component of xmlsitemap is never in-sync because it is re-acting to changes in content.

In particular:

  • max_filesize
  • updated

Is there a reason these values need to be included in config?
If they need to exist at all, is there a better place to store them?

Edit: These config values are stored in a site specific config file.

drush config-get xmlsitemap.xmlsitemap.NXhscRe0440PF…7u4e9aZwOM

Comments

travismiller created an issue. See original summary.

travismiller’s picture

travismiller CreditAttribution: travismiller commented
Issue summary: View changes
travismiller’s picture

travismiller CreditAttribution: travismiller commented

Looking through the module. I'm not seeing any instance of retrieving these values for usage.

  • Entity\XmlSitemap::getUpdated is never called.
  • Entity\XmlSitemap::getMaxFileSize is returned from xmlsitemap_sitemap_get_max_filesize.
    • xmlsitemap_sitemap_get_max_filesize is called from XmlSitemapGenerator::regenerateBatchGenerate without capturing return value.

http://cgit.drupalcode.org/xmlsitemap/tree/xmlsitemap.module?h=8.x-1.x#n426
http://cgit.drupalcode.org/xmlsitemap/tree/src/XmlSitemapGenerator.php?h...

joelstein’s picture

joelstein CreditAttribution: joelstein as a volunteer commented
Status: Active » Closed (duplicate)

I believe this was resolved in #2767647: Consider moving non-constant configuration values for specific sitemap instances out of config..