Recursive router rebuild detected error once you try to install the module [#2920771]

Problem/Motivation

Once you try to install the module you will see this message:

 [error]  RuntimeException: Recursive router rebuild detected. in /Users/adriancid/Sites/drupal83-test/core/lib/Drupal/Core/Routing/RouteBuilder.php:121
.....
#17 /Users/adriancid/Sites/drupal83-test/modules/contrib/xmlsitemap/xmlsitemap.install(307): Drupal\Core\Url->toString()
.....

The problem comes from this line:
\Drupal::state()->set('xmlsitemap_base_url', Url::fromRoute('<front>', [], ['absolute' => TRUE])->toString());

Proposed resolution

Not sure about why we get the error, but putting the code in a hook_update() solve the problem.

Remaining tasks

Test the patch

User interface changes

None.

API changes

None.

Data model changes

None.

Comment	File	Size	Author
#3	xmlsitemap-recursive_route_rebuild-2920771-3-D8.patch	1.61 KB	adriancid
#3	8.x-1.x: PHP 7 & MySQL 5.5, D8.5 Skipped, branch did not pass for 4 weeks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

3 November 2017 at 12:52

adriancid created an issue. See original summary.

Comment #2

adriancid

Spanish

Montreal, Canada

CreditAttribution: adriancid as a volunteer commented 3 November 2017 at 13:15

Issue summary:

View changes

Comment #3

adriancid

Spanish

Montreal, Canada

CreditAttribution: adriancid as a volunteer commented 3 November 2017 at 13:31

Issue summary:	View changes
Status:	Active	» Needs review

File	Size
xmlsitemap-recursive_route_rebuild-2920771-3-D8.patch	1.61 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.5 Skipped, branch did not pass for 4 weeks

I'm not sure why this problem is present but putting the code in a hook update solve the issue and the module seems to works.

Comment #4

remyyyyy

w4u

French

Tours

CreditAttribution: remyyyyy as a volunteer and commented 24 December 2017 at 09:38

module xmlsitemap
Mise à jour #8003
Échec : Drupal\Core\Entity\EntityStorageException : 'xmlsitemap' entity with ID '2e9ZfIfLFCC0V-PbcDKUTb1Wk22XgjzJ6f-b16CFlPE' already exists. dans Drupal\Core\Entity\EntityStorageBase->doPreSave() (ligne 425 de core/lib/Drupal/Core/Entity/EntityStorageBase.php)

Comment #5

GeduR CreditAttribution: GeduR at Metadrop commented 26 December 2017 at 09:15

Status:

Needs review

» Needs work

If the code is moved to the hook_update it will not be executed for new installations (Drupal gets the hight hook update number, stores it and only execute next updates). As the code resides in the hook_install it seems that the initial idea was to be executed on the first installation so moving to hook update could work but doesn't make sense as it is the same as removing the code.