Developer Mode results in Undefined Context Variable [#2831534]

In certain conditions, the following error occurs while generating the sitemap at /sitemap.xml

Message	Notice: Undefined variable: context in Drupal\xmlsitemap\Controller\XmlSitemapController->renderSitemapXml() (line 76 of /var/www/project/web/modules/contrib/xmlsitemap/src/Controller/XmlSitemapController.php)

This happens when I have the Enable developer mode to expose additional settings. Button checked. This button can be found in the Setting Tab -> Under Advanced Settings.

When I Uncheck the box and use the sitemap, it works fine.

Any ideas?

Comment	File	Size	Author
#5	xmlsitemap-developer_mode_results_in_undefined_context_variable-2831534-5.patch	647 bytes	alexandre.todorov
#5	8.x-1.x: PHP 7 & MySQL 5.5, D8.5 Skipped, branch did not pass for 4 weeks
#2	xmlsitemap-developer_mode_results_in_undefined_context_variable-2831534-2.patch	724 bytes	bkhandruk
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 November 2016 at 18:58

jonnyeom created an issue. See original summary.

Comment #2

bkhandruk CreditAttribution: bkhandruk commented 22 December 2016 at 17:25

Status:

Active

» Needs review

File	Size
xmlsitemap-developer_mode_results_in_undefined_context_variable-2831534-2.patch	724 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 1 fail

Replaced undefined variable $context with $sitemap->getContext() method.

Comment #3

ytsurk

Switzerland

CreditAttribution: ytsurk commented 20 February 2017 at 13:30

Works fine for me.

Comment #4

G42 CreditAttribution: G42 commented 9 June 2017 at 19:28

I can not replicate this problem, have you tried the latest version?

Comment #5

alexandre.todorov CreditAttribution: alexandre.todorov commented 11 August 2017 at 09:26

File	Size
xmlsitemap-developer_mode_results_in_undefined_context_variable-2831534-5.patch	647 bytes
8.x-1.x: PHP 7 & MySQL 5.5, D8.5 Skipped, branch did not pass for 4 weeks

As the meaning of "current_context" is to get the current context, I think it is better to use xmlsitemap_get_current_context() which returns the currently active context and not the sitemap one. In fact it is intended to be the same than $sitemap->context because of $sitemap = XmlSitemap::loadByContext();