XML Sitemap - broken URL's when including files [#2820002]

Problem/Motivation

Adding 'File' as a custom entity through the XML Sitemap configuration results in broken sitemap URL's.

Steps to reproduce

Configure Custom Entity Settings at: admin/config/search/xmlsitemap/entities/settings
Tick file, configure Sitemap Settings to be included, save changes
Rebuild sitemap links: admin/config/search/xmlsitemap/rebuild
Rebuild cron: admin/config/system/cron
Navigate to YOUR_DOMAIN/sitemap.xml
File links are broken

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#2	broken_file_url-2820002-2.patch	592 bytes	xiwar
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 1 fail
	sitemap_xml.png	642.48 KB	xiwar

Issue fork xmlsitemap-2820002

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2820002-xml-sitemap-- compare
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

18 October 2016 at 08:56

xiwar created an issue. See original summary.

Comment #2

xiwar CreditAttribution: xiwar at Redweb commented 19 October 2016 at 14:23

File	Size
broken_file_url-2820002-2.patch	592 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 57 pass, 1 fail PHP 7 & MySQL 5.5, D8.3 57 pass, 1 fail

I have attached a patch for this issue. This removes the duplicate host for file entities.

Comment #3

xiwar CreditAttribution: xiwar at Redweb commented 19 October 2016 at 14:24

Status:

Needs work

» Needs review

Comment #4

26 October 2016 at 19:34

Status:

Needs review

» Needs work

The last submitted patch, 2: broken_file_url-2820002-2.patch, failed testing.

Comment #5

jatinkumar1989 CreditAttribution: jatinkumar1989 commented 28 June 2017 at 02:15

Component:

Code

» xmlsitemap.module

Comment #6

jatinkumar1989 CreditAttribution: jatinkumar1989 commented 28 June 2017 at 02:17

Component:

xmlsitemap.module

» Code

Comment #7

Pranay Agarwal CreditAttribution: Pranay Agarwal commented 13 September 2017 at 09:37

#2 Thanks. Your solution is exactly what I was looking for.

Comment #8

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid as a volunteer and at Lullabot commented 8 June 2020 at 20:03

I don't believe file entities should be includable in the sitemap without something like the File Entity module. If we do need this still I would prefer this code live in a file_xmlsitemap_link_alter() hook implementation that we add to xmlsitemap.module on behalf of the core file module.

Comment #9

29 January 2021 at 22:50

ipo4ka704 made their first commit to this issue’s fork.

Comment #10

ipo4ka704 CreditAttribution: ipo4ka704 at EPAM Systems commented 30 January 2021 at 11:43

As I see after this commit https://www.drupal.org/project/xmlsitemap/issues/3079398#comment-13681272 we can't include files entity type for xmlsitemap, so I think we can close this issue.