To help reduce file size if wanted.

CommentFileSizeAuthor
#17 after.png52.59 KBankondrat4
#17 before.png42.52 KBankondrat4
#9 2416897-9-d8-port.patch4.63 KBedwardchiapet
#8 2416897-8-d8-port.patch4.63 KBweekbeforenext
#7 2416897-7-d8-port.patch4.63 KBweekbeforenext
#6 2416897-6-d8-port.patch4.73 KBweekbeforenext
#5 2416897-5-d8-port.patch4.78 KBweekbeforenext
#2 2416897-disable-lastmod-changefreq-priority-elements.patch3.61 KBdave reid
#1 2416897-disable-lastmod-changefreq-priority-elements.patch3.06 KBdave reid

Issue fork xmlsitemap-2416897

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2416897-disable-lastmod-changefreq-priority-elements.patch3.06 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 2416897-disable-lastmod-changefreq-priority-elements.patch3.61 KB

Missing entry in xmlsitemap_variables()

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-2.x-dev » 8.x-1.x-dev
Assigned: dave reid » Unassigned
Status: Needs review » Patch (to be ported)

Committed #2 to 7.x-2.x.

  • Dave Reid committed cd45c8b on 7.x-2.x 
    Issue #2416897 by Dave Reid: Allow disabling output of lastmod,...
weekbeforenext’s picture

weekbeforenext
Primary language English
Location Asheville, NC
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 2416897-5-d8-port.patch4.78 KB

I took a stab at porting this to D8.

weekbeforenext’s picture

weekbeforenext
Primary language English
Location Asheville, NC
commented
StatusFileSize
new 2416897-6-d8-port.patch4.73 KB

Left a dump() in there... New patch file.

weekbeforenext’s picture

weekbeforenext
Primary language English
Location Asheville, NC
commented
StatusFileSize
new 2416897-7-d8-port.patch4.63 KB

Removed diff of the patch file...

weekbeforenext’s picture

weekbeforenext
Primary language English
Location Asheville, NC
commented
StatusFileSize
new 2416897-8-d8-port.patch4.63 KB

Fixed an issue with the patch. This one should be good to go (fingers crossed).

edwardchiapet’s picture

edwardchiapet
Location New York, NY
commented
StatusFileSize
new 2416897-9-d8-port.patch4.63 KB

Patch re-rolled for 8.x-1.0-rc1.

Status: Needs review » Needs work

The last submitted patch, 9: 2416897-9-d8-port.patch, failed testing. View results

ipo4ka704 made their first commit to this issue’s fork.

ipo4ka704 opened merge request !12

ipo4ka704’s picture

ipo4ka704 commented
Status: Needs work » Needs review

Updated patch and fixed logic. Now it is working. Please review

kthull’s picture

kthull
He/him
Primary language English
Location Fort Wayne, Indiana
commented

#12 applied against Version: 8.x-1.2 and worked as expected.

ysamoylenko’s picture

ysamoylenko commented
Status: Needs review » Reviewed & tested by the community

I can confirm that #12 fix the issue.

Happy to RTBC!

ankondrat4’s picture

ankondrat4 commented
Version: 8.x-1.x-dev » 8.x-1.4

Hello.

Don't apply to xmlsitemap 8.x.-1.4

ankondrat4’s picture

ankondrat4 commented
StatusFileSize
new before.png42.52 KB
new after.png52.59 KB

After review MR!12 and did rebase its work.
Looks good to me. +1 RTBC

Attaching screenshots for reference.