Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I had a hard time figuring out what made one of my Drupal installations eat up all allowed memory before returning:
Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 46 bytes) in D:\drupal\includes\menu.inc on line 3723
I am sure it has something to do with XML Sitemap Menu, but maybe it's not an actual bug. Allow me to explain: to reproduce the error I used a clean standard Drupal 7.15 installation with just XML Sitemap and XML Sitemap Menu enabled, plus a custom module containing only the next function:
function custommodule_url_inbound_alter($path, $original_path, $path_language) {
drupal_valid_path($path);
}
When creating a new content type (admin/structure/types/add), the site eats up the memory and errors. Apparently drupal_valid_path() eventually triggers XML Sitemap Menu which eventually triggers hook_url_inbound_alter() again, and a loop is created.
As said, I do not know if this is an actual bug, considering these rare conditions, but still my guess is that the loop is something to prevent other users from getting stuck in...
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 1788284-anti-recursion-7.patch | 727 bytes | bucefal91 |
| |||
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedI don't see how this can be an xmlsitemap issue. The drupal_get_normal_path() function is what invokes the hook_url_inbound_alter() and there are 12 core functions at api.drupal.org I find that calls drupal_get_normal_path(). There are two functions in xmlsitemap that call drupal_get_normal_path but I don't find that drupal_valid_path() is involved with drupal_get_normal_path() to cause a loop. However, your use case of the hook to me appears to be invalid. For one the 1st parameter of the hook should be call by ref and you have it as call by value (i.e. it should be &$path and you have $path). More research is needed, it will be a while before I can get back to it.
Comment #2
-sibero- CreditAttribution: -sibero- commentedThere was the same problem. In my case, the problem was in the module subpathauto-7.x-1.3 - issue - http://drupal.org/node/1790508
Sorry for bad English.
Comment #3
diego21 CreditAttribution: diego21 commentedI had same problem. I had drupal 7.15 on kubuntu 12.04, xml sitemap 7.x-2.0-rc1 and subpathauto 7.x-1.3. I couldn't add content, delete existing nodes or even flush all caches without get that error or similars ( http://drupal.stackexchange.com/questions/46293/increase-memory-limit-do... ). I tried everything: increasing memory_limit in php.ini to 700MB (my laptop only has 1024MB of RAM), increasing max_execution_time to 360s in php.ini!! (because at first it was "PHP Fatal error: Maximum execution time of 30 seconds exceeded"). But when I deleted xml sitemap from my drupal installation, all worked well again. I don't know why this happens. Thanks Imeurs.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedRelated core issue #1815354: menu_get_item when called from hook_url_inbound_alter causes infinite loop.
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedThis really isn't an xmlsitemap issue but waiting for a resolution to the core issue.
Comment #6
stBorchertWe provided a patch to Sub-pathauto to fix the propblem there. See https://drupal.org/node/1790508#comment-7786395 for the patch.
Comment #6.0
stBorchertSmall textual alteration
Comment #7
bucefal91 CreditAttribution: bucefal91 at Websolutions Agency commentedI am having the same trouble. In my case it was xmlsitemap_menu + og_content modules enabled.
As far as I studied the problem, it appears to me the following way:
xmlsitemap_menu_menu_link_alter()hook gets invoked as a part of the rebuild process.menu_link_load()on the link it alters. Keep in mind that we are still rebuilding the menu router, i.e. stuff is cold/unstable in the menu component of drupal core.menu_link_load()in a few spots the core might invoke some contrib space code. In the case of og_content module it was the to_arg_functions callback (og_content_to_arg()) which invokesmenu_get_item()to get the default args.I think XML sitemap menu module does need to load menu link afresh (
menu_link_load()I am attaching a patch that implements this "fuse" logic. It does dissolve my problem. I do not insist to include this patch into the module (I am not sure I'd be happy to include such thing into a module I maintain :) but at least it provides some sort of solution for all the mortals out there who "need this damn thing to work").
Comment #8
renatogI applied the patch #7 and it really works well. Thank you so much for your contribution on that +1 to it
Comment #10
renatogMoved to the dev branch
Thank you so much @bucefal91
Comment #12
renatogSorry team, reverted because I think that will be necessary working on tests for this