I spent a lot of time trying to determine why wysiwyg_filter wasn't modifying the form altered by input formats module.

It seems the current inclusion of wysiwyg_filter.admin.inc in wysiwyg_filter_filter (when $op == 'settings') doesn't always works. I meant, the inclusion of an inc file to execute a form alter.

This patch just moves the implementation of the hook_FORM_ID_alter from wysiwyg_filter.admin.inc to wysiwyg_filter.module. This is the only way I founded to give a change to alter "again" the configuration for of the input format.

Sorry, for this short explanation, but, explain this more detailed is a bit difficult, but I would appreciate this get in before next release of wysiwyg_filter.

Thanks again.

CommentFileSizeAuthor
wysiwyg_filter-form-alter.patch2.44 KBdagmar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dagmar’s picture

Status: Active » Needs review

I forgot change the status.

bleen’s picture

I just tried the patch in #1 and I still get the errors below whenever I include "WYSIWYG Filter" as port of one of my input filters. Additionally, I still have weirdness with my admin-theme changing back and fourth between Rubik & Garland:

warning: implode() [function.implode]: Invalid arguments passed in /sites/all/modules/contrib/wysiwyg_filter/wysiwyg_filter.admin.inc on line 107.
warning: implode() [function.implode]: Invalid arguments passed in /sites/all/modules/contrib/wysiwyg_filter/wysiwyg_filter.admin.inc on line 107.
warning: implode() [function.implode]: Invalid arguments passed in /sites/all/modules/contrib/wysiwyg_filter/wysiwyg_filter.admin.inc on line 107.
warning: implode() [function.implode]: Invalid arguments passed in /sites/all/modules/contrib/wysiwyg_filter/wysiwyg_filter.admin.inc on line 146.

UPDATE: I didn't actually apply the patch in #1 .. I just moved the function in question from admin.inc to .module

bleen’s picture

alexbk66-’s picture

I have the same problem, there's related issue #885632: Don't export variables with a default value. It's closed, but is it fixed?

warning: Invalid argument supplied for foreach() in .../modules/wysiwyg_filter/wysiwyg_filter.inc on line 523
implode() [<a href='function.implode'>function.implode</a>]: Invalid arguments passed in .../modules/contrib/wysiwyg_filter/wysiwyg_filter.admin.inc on line 146.

I tried to move 'function wysiwyg_filter_form_filter_admin_configure_alter' from wysiwyg_filter.admin.inc to wysiwyg_filter.module, no difference.

What's strange, I cant change Rules for URLs used within inline styles anymore, it's always empty. I removed all HTML elements and attributes, but still getting:

The style attribute is used in your HTML elements and attributes rules, and you have enabled one of the following style properties: "background", "background-image", "list-style" or "list-style-image". You should specify the Rules for URLs used within inline styles field in the "Advanced rules" section below. Leaving it unspecified will result in all URLs used within inline styles filtered out

Any ideas?

alexbk66-’s picture

Update.

I disabled Form.module and it's all good now!

stefan.r’s picture

Issue summary: View changes
Status: Needs review » Closed (won't fix)

Does not apply to 7.x as Input formats is 6.x only, closing this issue.