Profiling wysiwyg_filter_parse_valid_elements(), its slow and called a lot

This is great! I had one view that was reporting 1.3secons and this patch brought that down to 2ms!

Thanks @heddn

Here's a git diff -w . view of that patch because it looks bigger than it is.

diff --git a/sites/all/modules/contrib/wysiwyg_filter/wysiwyg_filter.inc b/sites/all/modules/contrib/wysiwyg_filter/wysiwyg_filter.inc
index c76308b..8614093 100644
--- a/sites/all/modules/contrib/wysiwyg_filter/wysiwyg_filter.inc
+++ b/sites/all/modules/contrib/wysiwyg_filter/wysiwyg_filter.inc
@@ -123,6 +123,9 @@ function wysiwyg_filter_get_elements_blacklist() {
  * @see wysiwyg_filter_process()
  */
 function wysiwyg_filter_parse_valid_elements($valid_elements) {
+  $parsed_elements = &drupal_static(serialize($valid_elements));
+
+  if (!isset($parsed_elements)) {
     // Remove whitespaces and split valid elements from a comma separate list of items into an array.
     $valid_elements = array_map('drupal_strtolower', array_filter(explode(',', preg_replace('#\s+#', '', $valid_elements))));
     $parsed_elements = array();
@@ -260,6 +263,7 @@ function wysiwyg_filter_parse_valid_elements($valid_elements) {

     // Sort HTML elements alphabetically (for filter tips).
     ksort($parsed_elements);
+  }

   return $parsed_elements;
 }

@heddn it may be worth writing that with a an early return to make the diff smaller and less indenting?

aka:

$parsed_elements = &drupal_static(serialize($valid_elements));
if (isset($parsed_elements)) {
  return $parsed_elements;
}

Let you or the maintainer decided which is preferred

I lean towards smaller patches myself, so just putting up joelpittet's suggestion in case the maintainer feels the same. But credit for this issue should go to heddn and joelpittet for seeing/fixing/testing the problem. Thanks guys!