Hi, good work on a great filter, and I look forward to the D7 release, I still haven't found an effective replacement.

I'm using this filter with ckEditor.

I'm really like the spam link deterrent whitelist, but have just noticed that all relative links in my content are being screened out by the filter.

I can of course add all the links as absolute, but then that will stuff things up when I grab the site to work on it locally.

I have pages that aren't in menus or linked from other places outside the content, so this is really bad for SEO as none of them will be indexed by robots.

I can't see the harm in allowing relative links as they can never link outside the site anyway.
Can this be incorporated into the filter?

CommentFileSizeAuthor
#7 wysiwyg_filter-nofollow-on-relative-links-1077900-7.patch973 bytesDrIPA
#5 rel_nofollow_goes-1077900-5.patch968 bytesJohnny vd Laar
#4 wysiwyg_filter-nofollow-on-relative-links-1077900-4.patch986 bytesrgristroph
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vinmassaro’s picture

vinmassaro CreditAttribution: vinmassaro commented

Subscribing. I just ran into this as well - rel=nofollow is being added to relative links, particularly to PDFs being linked to internally.

dsrikanth’s picture

dsrikanth CreditAttribution: dsrikanth commented

Was this resolved? I think this is critical at least with respect to SEO to be able to whitelist internal links

HyperGlide’s picture

HyperGlide CreditAttribution: HyperGlide commented

Follow up to #2 was this resolved in the 6.x and 7.x branch?

Thank you.

rgristroph’s picture

rgristroph CreditAttribution: rgristroph commented
Issue summary: View changes
FileSize
wysiwyg_filter-nofollow-on-relative-links-1077900-4.patch986 bytes

I ran into this problem on the Drupal 7 version.

The problem was that when doing a whitelist nofollow policy, if there is a relative link, it does not find a domain from the whitelist, because there is no domain at all, and then it adds the rel="nofollow". I made it check for a leading "/" as a way of detecting the relative link.

Note that the attached patch is for the Drupal 7 version -- I will see about re-rolling it for Drupal 6 as well.

Johnny vd Laar’s picture

Johnny vd Laar CreditAttribution: Johnny vd Laar at ezCompany commented
Version: 6.x-1.5 » 7.x-1.x-dev
Status: Active » Needs review
FileSize
rel_nofollow_goes-1077900-5.patch968 bytes

node/12 is also a relative path and doesn't have a leading slash. I modified the check to see if the link contains ://. If not then it is relative.

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented

I modified the check to see if the link contains ://

That could unintentionally leave protocol relative URLs like //example.com/foo/bar alone.
Would parse_url() serve us better?

DrIPA’s picture

DrIPA CreditAttribution: DrIPA commented
FileSize
wysiwyg_filter-nofollow-on-relative-links-1077900-7.patch973 bytes

Would parse_url() serve us better?

Yes, this will also validate // as an external url.

I've added a new patch

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Component: Miscellaneous » Code
Category: Feature request » Bug report
Status: Needs review » Reviewed & tested by the community

Works for me! I'd say this is a bug and a major one too...

  • axel.rutz committed 9483291 on 7.x-1.x 
    Issue #1077900 by rgristroph, Johnny vd Laar, e.ruiter, axel.rutz: rel="...
  • axel.rutz committed ae38ec8 on 7.x-1.x
    Simplified nofollow condition to prepare #1077900
geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at MachbarMacher commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.