wysiwyg and fckeditor - problems with image upload and browse server

It seems that Drupal is squirting out these settings in the document head. All those falses are what's causing the problem. How do I set them to true?

<script type="text/javascript">
<!--//--><![CDATA[//><!--
jQuery.extend(Drupal.settings, { "basePath": "/", "wysiwyg": { "configs": { "fckeditor": { "format3": { "EditorPath": "/sites/all/libraries/fckeditor/", "SkinPath": "/sites/all/libraries/fckeditor/editor/skins/default/", "CustomConfigurationsPath": "/sites/all/modules/wysiwyg/editors/js/fckeditor.config.js", "Width": "100%", "Height": 420, "LinkBrowser": false, "LinkUpload": false, "ImageBrowser": false, "ImageUpload": false, "FlashBrowser": false, "FlashUpload": false, "IncludeLatinEntities": false, "IncludeGreekEntities": false, "FontFormats": "p;address;pre;h2;h3;h4;h5;h6;div", "FormatSource": 0, "FormatOutput": 0, "EditorAreaCSS": "/sites/all/themes/cache/style.css" } },  .....  });
//--><!]]>
</script>

OK. The defaults appear to be set in the wysiwyg module in the file editors/fckeditor.inc

...
function wysiwyg_fckeditor_settings($editor, $config, $theme) {
  $settings = array(
    'EditorPath' => base_path() . $editor['library path'] . '/',
    'SkinPath' => base_path() . $editor['library path'] . '/editor/skins/' . $theme . '/',
    'CustomConfigurationsPath' => base_path() . drupal_get_path('module', 'wysiwyg') . '/editors/js/fckeditor.config.js',
    'Width' => '100%',
    'Height' => 420,
    'LinkBrowser' => FALSE,
    'LinkUpload' => FALSE,
    'ImageBrowser' => FALSE,
    'ImageUpload' => FALSE,
    'FlashBrowser' => FALSE,
    'FlashUpload' => FALSE,
    // By default, FCKeditor converts most characters into HTML entities. Since
    // it does not support a custom definition, but Drupal supports Unicode, we
    // disable at least the additional character sets. FCKeditor always converts
    // XML default characters '&', '<', '>'.
    // @todo Check whether completely disabling ProcessHTMLEntities is an option.
    'IncludeLatinEntities' => FALSE,
    'IncludeGreekEntities' => FALSE,
  );

...

}

Changing them to 'TRUE' solves the problem. But isn't there a better way to do this in site configuration/wysiwyg?

I think I have got to the bottom of this. I thought I'd post what I've done here in case it sparks an improvement - which I think this functionality might do.

This is how I've created the possibility for editor specific options under admin/settings/wysiwyg.

1. Create a new file called 'fckeditor.admin.inc' and stick it alongside 'fckeditor.inc' in the wysiwyg module's 'editors' folder. This new file contains one function that defines the editor-specific admin form we want.

function wysiwyg_fckeditor_form($form_state, $profile) {
  $form = array();
  $form['fck'] = array(
    '#type' => 'fieldset',
    '#title' => t('FCKeditor Options'),
    '#collapsible' => TRUE,
    '#collapsed' => TRUE,
  );

  $form['fck']['image_browser'] = array(
    '#type' => 'checkbox',
    '#title' => t('Enable image browsing'),
    '#default_value' => $profile->settings['image_browser'],
    '#return_value' => 1,
    '#description' => t('Allow users to browse the server for images to include.'),
  );

  $form['fck']['image_upload'] = array(
    '#type' => 'checkbox',
    '#title' => t('Enable image uploads'),
    '#default_value' => $profile->settings['image_upload'],
    '#return_value' => 1,
    '#description' => t('Allow users to upload images onto the server.'),
  );
  
  return $form;
}

2. Add the following lines into 'wysiwyg.admin.inc' in the wysiwyg_profile_form function, just above the first definition of $form['basic']:

  ... 

  // Create editor specific admin menu
  $func = 'wysiwyg_'.$profile->editor.'_form';
  if (function_exists($func)) $form = array_merge($form,$func($form_state, $profile));

  $form['basic'] = array(
    '#type' => 'fieldset',
    '#title' => t('Basic setup'),
    '#collapsible' => TRUE,
    '#collapsed' => TRUE,
  );

  ... 

3. Update the function wysiwyg_fckeditor_settings in fckeditor.inc to include the following lines anywhere after the default settings are defined (see #3 - just after this is fine)

  ...

  if (isset($config['image_browser'])) {
    $settings['ImageBrowser'] = $config['image_browser'];
  }
  if (isset($config['image_upload'])) {
    $settings['ImageUpload'] = $config['image_upload'];
  }

  ...

That way the admin settings only appear if you have set the editor to fckeditor in this case, and the settings in the admin section overwrite the default ones hard-coded into fckeditor.inc.

It would probably be worth doing the same thing for the other values (LinkBrowser, LinkUpload, FlashBrowser and FlashUpload), but the image ones were the only ones I was interested in changing.

Any use?