As they slighly changed their header and size, the fgets 140 splits the version line in 2 pieces, what finally leads the regexp to not match.

Patch attached, highered lenght to 500.

CommentFileSizeAuthor
wysiwyg_ckeditor_version.patch508 bytesEugenMayer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TwoD’s picture

Version: 6.x-2.3 » 7.x-2.x-dev
Status: Needs review » Fixed

Thanks!
I found no changes in the nightly build that would affect Wysiwyg so this has been committed to all branches.

The snapshots will be updated within 12 hrs and will then be able to detect CKEditor 3.5.4.
We should try to publish a new minor version before 3.5.4 is realeased, and check that the latest versions of the other editors are recognized as well.

EugenMayer’s picture

Title: Newer ( 3.5.4 ) CKeditor version not by ckeditor.inc » Newer ( 3.5.4 ) CKeditor version not detected by ckeditor.inc

Well i will be checking the CKEditor on every release, so leave that one to me. i will report with fixes in the queue pretty early, if there are any. We are upgrading during one week on every release, rather earlier, and often testing the nighly builds due to all that issues with the FF / Safari stuff.

Just for the people reading this, when you are using ckeditor > 3.5.2 you will have issues with the Firefox browser, when you have something like tabs on the editor form (or a dialog or anything else "hiding" ( css, display:none ) the editor and showing it again). It comes down to the setting that disables the build-in CKEditor spell-checker ( disableWhatever .. ) .. Dont disable it and it will work again. There is no fix for this in CKeditor, not even in the nightly build.

TwoD’s picture

Great, and thanks for the info on the FF issue!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

joachim’s picture

Just a note to say the fix for this is in 6.x-2.4 too.

gagarine’s picture

Title: Newer ( 3.5.4 ) CKeditor version not detected by ckeditor.inc » Newer ( 3.6.3 ) CKeditor version not detected by ckeditor.inc
Status: Closed (fixed) » Active

Same bug again

gagarine’s picture

Status: Active » Closed (fixed)

Oups sorry my bad... I have two folder ckeditor/ckeditor . So it's just a bad error message but version detection works.