Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hello
In first of all, thank you for your theme. I very like it.
I have tried to enable the theme Writer and I've got a trouble with the header. It doesn't looks as on your demo
Desktop:
Mobile:
Seems the reason of problem is that structure of the page.html.twig in D8 is not the same as structure of page.tpl.php in D7.
Logo, site name and slogan are provided by "System branding block" in D8, but not directly in the page.tpl.php as in D7.
I think that the best solution is override template block--system-branding-block.html.twig for theme Writer and adapt it's structure to display content as on your demo.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Selection_009.jpg | 27.77 KB | eugene.ilyin |
| #5 | Selection_008.jpg | 204.1 KB | eugene.ilyin |
| #5 | writer-put-header-into-order-2662854-5-D8.patch | 2.56 KB | eugene.ilyin |
| #3 | Selection_005.jpg | 3.81 KB | eugene.ilyin |
| #3 | Selection_004.jpg | 12.81 KB | eugene.ilyin |
Comments
Comment #2
eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commentedComment #3
eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commentedI suggest this patch to correct the problem.
After applying this patch it looks correct.
Desktop:
Mobile:
Comment #4
bryanbraun CreditAttribution: bryanbraun commentedThanks for finding and reporting the issue. Your fix looks promising. Give me a chance to test it out and if all looks well we'll get it updated.
Comment #5
eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commentedI've updated the patch to fix other issue with the crossed dates
Also I have a question about this
Seems there are no property 'settings.node.submitted'. I've found only property "display_submitted".
Why does it need? Right now 'settings.node.submitted' is always empty and it's the reason of issue with big padding in mobile version.
Comment #6
eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commentedComment #7
bryanbraun CreditAttribution: bryanbraun commentedGood question. That's probably left over from porting this theme from Drupal 7. I ported it early and the API was still changing a lot at that point. If you know of a fix, I can roll it into this issue, otherwise we can create a separate issue to track that.
Comment #8
eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commentedOkay, I'll investigate D7 version to find the true sence for this property.
Comment #10
bryanbraun CreditAttribution: bryanbraun commented@eugene.ilyin, I tested your fix and it works great.
I didn't realize it was so broken because I wasn't running the latest version of D8 locally. Once I updated to the latest, I saw the things you were seeing, along with several other issues. :/
I've pushed up your patch to 8.x-2.x-dev. I'm going to close this issue as fixed, an open new issues for the other things you mentioned. Thanks again for the help!
Comment #11
bryanbraun CreditAttribution: bryanbraun commentedFYI, I created #2668420: Oversized Padding at Mobile Widths for the padding issue you reported.
Comment #12
bryanbraun CreditAttribution: bryanbraun commentedOne last note to @eugene.ilyin, the issue you reported with the extra padding has been fixed in #2668420: Oversized Padding at Mobile Widths and released as part of 8.x-2.2-rc1.
Comment #13
eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented@bryanbraun Thank you very much.