The function WorkflowTransition::isEmpty() checks if anything has changed to decide if a transition must be logged.
For attached fields (to Transitions), this generates a problem if only an attached field has changed.
So, enhance this function.

CommentFileSizeAuthor
#3 workflow-isempty_for_attachedfields-2927663-3.patch959 bytesrobertom
#2 workflow_2927663_2_isEmpty_for_AttachedFields.patch914 bytesjohnv
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

johnv created an issue. See original summary.

johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Status: Active » Needs work
Related issues: +#2899025: Attached field type 'file' not working on WorkflowTransition
FileSize
workflow_2927663_2_isEmpty_for_AttachedFields.patch914 bytes

This is a first attempt. It seems too specific, and we need to solve #2899025: Attached field type 'file' not working on WorkflowTransition first.

robertom’s picture

robertom CreditAttribution: robertom at bmeme commented
Status: Needs work » Needs review
FileSize
workflow-isempty_for_attachedfields-2927663-3.patch959 bytes

attached a more general patch (I think)

Status: Needs review » Needs work

The last submitted patch, 3: workflow-isempty_for_attachedfields-2927663-3.patch, failed testing. View results

johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Related issues: +#2988650: EntityReferenceItem::isEmpty returns TRUE when field contains value

Lets see how he core patch #2988650: EntityReferenceItem::isEmpty returns TRUE when field contains value develops.

  • johnv committed 8af523f on 8.x-1.x authored by robertom 
    Issue #2927663: Enable function WorkflowTransition::isEmpty() for...
johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Version: 8.x-1.x-dev » 8.x-1.1
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.