Improve UI: turn workflow fieldset in node form to a vertical tab

Well, it's only a start, but here's a patch that moves the content type mapping form onto a separate menu tab.

*EDIT*

I will learn to read some day. This patch is for the workflow configuration page.

deleted

I had my way, the workflow form would not even be shown on the node edit form. I don't think it works right there.

Done

yes, this should be a vertical tab but i think it is currently done wrong (and not how it used to be - which was done correctly).

at first i thought the hook_field_extra_fields call was missing; but no; it is there and it seems to be done right. it returns a tab in manage field called Workflow: http://screencast.com/t/LMZgjIJEE

but on the edit form this is blank (my 2 fields that were added in to the Workflow field_group are all that show: http://screencast.com/t/CuGmjcpXAr7e

there is a Survey Status tab on the edit form which is the name of my workflow so i think when this patch was done it moved the workflow form into a tab which is now called Survey Status but it is no longer tied to the one from extra fields (i.e. manage fields page).

Vertical Tabs are NOT extra_fields, so that has been removed in the latest dev.

Since the basic mechanism has changed, this can no longer be done with field groups. It must be done with a hook_form_alter().

Personally, I would prefer it back as an extra_field; that made more sense to me. But, as you can see, some people seem to think a) having this on node edit is a good idea; b) it was "cluttered." I disagree with both assertions.

And so now, not only are you upset and pushed to a harder implementation, but there is also a spurious H3 tag that I am wasting time trying to get rid of.

yes, maybe i am saying it wrong. not that my opinion matters; but i guess i am saying moving it to a vertical tab rather than an extra field is silly. as an extra field it can be moved wherever; such as in a vertical tab if the developer wants or, as i was doing, mixed in a vertical tab with some other fields that are also sort of workflow related.

but i see what the change is now that has "broken" this. it is that is now forced in to its own vertical tab so i will need to do a form_alter as you say (actually an #after_build) to put this back where i wanted it.

thanks for clearing this up for me.

So you feel that I should revert this change? I am not opposed.

+1 for using hook_field_extra_fields. The vertical tabs are OK for super-users, but for 'normal' editors, I try to get everything in Field UI fields, which allows me to choose the most logical place for each field (including the workflow field).

OTOH, supporting all UI wishes, might be sourced out to the Workflow_extensions module. (For me, a workflow field with out-of-the-box Field API widgets and formatters would be ideal)

Change reverted. It is back to extra fields.

@johnv: There is another issue about going to Fields.

@NancyDru, I couldn't find a Field issue, so I started #2019345: Create a 'Workflow Field' with Widget, Formatter, Fieldtype