This commit to uuid_link gives what looks like to me as usefull functionality.

http://cgit.drupalcode.org/uuid_link/commit/?id=1f61e03dd1955e91da8ad010...

CommentFileSizeAuthor
#10 wetkit_core4x_display_entity_label_and_UUID_in_dialog-2484927-10.patch679 bytesjoseph.olstad
#10 wetkit_core1x_display_entity_label_and_UUID_in_dialog-2484927-10.patch679 bytesjoseph.olstad
#8 linkit_uuid-2484927-8.patch3.66 KBjoseph.olstad
#8 interdiff_patch3_to_patch8.txt873 bytesjoseph.olstad
#3 linkit_uuid-2484927.patch3.84 KBsylus

Comments

sylus’s picture

sylus commented
Status: Needs review » Closed (works as designed)

We actually use linkit UUID rendering dialog instead of uuid link which is more treated as a fallback. An argument might be made for removing UUID link at some point since linkit handles it now for us.

sylus’s picture

sylus commented
Status: Closed (works as designed) » Active

Actually I am wrong there are a few people using this fallback so might as well take the patch.

sylus’s picture

sylus commented
StatusFileSize
new linkit_uuid-2484927.patch3.84 KB
sylus’s picture

sylus commented
Status: Active » Fixed

Fixed.

  • sylus committed b1e6849 on 7.x-4.x 
    Fixed WetKit Core for Issue #2484927 by sylus: Display entity label and...

  • sylus committed e29d1f7 on 
    Fixed WetKit Core for Issue #2484927 by sylus: Display entity label and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new interdiff_patch3_to_patch8.txt873 bytes
new linkit_uuid-2484927-8.patch3.66 KB

There was a type-o in patch number 3, the variable '$type' should have been '$entity_type'. The new patch resolves the error "Undefined variable: type in uuid_link_form_post_render()" please take the new patch.

See drupal.org API docs the function entity_label() takes '$entity_type' as a parameter, not '$type'

See attached patch (patch 8) and interdiff.

I will also report this upstream in uuid_link as they'll have to update the dev branch upstream as well.

Sylus, please update wetkit_core.make for 4.x and 1.x branches with the updated patch in patch 8

GDaw and I tested the new patch and it is good.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Parent issue: » #2532214: Display entity label and UUID in dialog type-o
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new wetkit_core1x_display_entity_label_and_UUID_in_dialog-2484927-10.patch679 bytes
new wetkit_core4x_display_entity_label_and_UUID_in_dialog-2484927-10.patch679 bytes

including patch for 4x and 1x wetkit_core.make file (needs backporting to 1.x )

Thanks

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

interdiff between patch #3 and patch #8

One line change

Before:

-            $uuids[$entity_type][$entity->uuid] = t('[@language] @label', array('@language' => $entity->language, '@label' => entity_label($type, $entity)));

After:

+            $uuids[$entity_type][$entity->uuid] = t('[@language] @label', array('@language' => $entity->language, '@label' => entity_label($entity_type, $entity)));

so undefined variable $type (passed as a parameter to entity_label()

should be $entity_type

Thanks

sylus’s picture

sylus commented
Status: Reviewed & tested by the community » Fixed

Committed and attributed.

  • sylus committed 88164b3 on 7.x-4.x authored by joseph.olstad 
    Fixed WetKit Core for Issue #2484927 by joseph.olstad, sylus: Display...

  • sylus committed 9214bde on authored by joseph.olstad 
    Fixed WetKit Core for Issue #2484927 by joseph.olstad, sylus: Display...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.